Replies: 1 comment
-
Thanks for picking this up @roopeshsn. Please note that we're going to deprecate async server very soon. It would be better if you design the feature wrt the resp server (the multi-threaded one). |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi, Team! I am going through TLS to implement in DiceDB for a couple of weeks now. As mentioned in issue #549, I found ways for implementation except at the 3rd point. I am thinking to start with AsyncServer (internal/server/server.go), as it will be invoked if
enable-multithreading
is false (single-threaded). The current implementation of AsyncServer is that it uses functions from thesyscall
package (to read and write the TCP payload) rather than thenet
package (net.Listen
for example).tls.Listen
usesnet.Listen
to listen to the port. I am not sure how I can introducetls.Listen()
to the existing listener:dice/internal/server/server.go
Line 151 in 03debc1
Your help and guidance is highly appreciated! @JyotinderSingh @soumya-codes
Beta Was this translation helpful? Give feedback.
All reactions