Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Album covers not caching? #86

Open
chowbok opened this issue Jan 4, 2024 · 7 comments
Open

Album covers not caching? #86

chowbok opened this issue Jan 4, 2024 · 7 comments

Comments

@chowbok
Copy link

chowbok commented Jan 4, 2024

The config claims that the album covers are cached, but it seems to reload them every time I start up the app. If it is loading them from the cache, it's doing it very slowly.

@Difegue
Copy link
Owner

Difegue commented Mar 28, 2024

👋 I'm not quite sure what to say -- The loading should be (and is on my machine) instantaneous. We save the full-size album art so some of the cached files can be quite heavy depending on your library, but normally nothing egregious.

The album art cache can be browsed in File Explorer at %LOCALAPPDATA%\Packages\13459Difegue.Stylophone_zd7bwy3j4yjfy\LocalState\AlbumArt -- Maybe the covers aren't saving there properly?

@chowbok
Copy link
Author

chowbok commented Mar 28, 2024

How many covers are you loading?

@Difegue
Copy link
Owner

Difegue commented Mar 28, 2024

One per album.
When it comes to the library view we wait to get the full album information from mpd before loading cover art, but I guess we could load cached data faster there if we already have it since all it needs is the album title

@chowbok
Copy link
Author

chowbok commented Mar 28, 2024

What I was getting at was that if it's working fine for you, maybe you have less albums to load? Because I have around 4000.

FWIW, Cantata loads them instantly, so it is possible.

@Difegue
Copy link
Owner

Difegue commented Mar 28, 2024

Ah right, my mistake - I have around 1500 here. I believe Cantata doesn't rely on the albumart command.

@chowbok
Copy link
Author

chowbok commented Mar 28, 2024

I looked in that cache directory and the artwork is being saved there. Does it check with the server before loading the cached image?

@Difegue
Copy link
Owner

Difegue commented Mar 29, 2024

It does - I've pushed some changes to try loading from cache before contacting the server, but it still won't be instantaneous due to WIndows.Storage being a fairly slow API + the fact we don't store small/bitcrushed version of cover art, so decoding can take some time depending on how large the coverart is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants