Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong results #1

Open
mcgist opened this issue Aug 30, 2019 · 0 comments
Open

Wrong results #1

mcgist opened this issue Aug 30, 2019 · 0 comments

Comments

@mcgist
Copy link

mcgist commented Aug 30, 2019 •
edited
Loading

Dimitris,
unfortunately your calendar provides wrong results, your implementation does not take into account the various special rules around eastern Easter dates.
FX:

  • correct Easter date Year 1994: Julian calendar: April 18, 1994, Gregorian calendar: May 1, 1994
  • your false Easter date Year 1994: Julian calendar: April 31, Gregorian calendar: March 27

Your implementation makes wrong use of the Paschal Full Moon (PFM) tables like described here: https://www.assa.org.au/edm#OrthCalculator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mcgist