Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uso inadecuado de concurrencia. #22

Open
le99 opened this issue Mar 27, 2015 · 0 comments
Open

Uso inadecuado de concurrencia. #22

le99 opened this issue Mar 27, 2015 · 0 comments
Assignees
Labels

Comments

@le99
Copy link

le99 commented Mar 27, 2015

En "event_manager/models.py":

@receiver(post_save, sender=Alarm)
def alarm_handler(sender, instance, created, **kwargs):
if created:
# Create a email with alarm
d = threading.Thread(name='daemon', target=send_email(instance))
d.setDaemon(True)
try:
d.start()
except:
print ("Error in check_schedule.")
print traceback.format_exc()
d.join()
instance.notified = True
instance.activated = False
instance.save()

En ese metodo se crea un thread (que es una operacion potencialmente costosa), e inmediatamente despues se bloquea al thread principal esperando al otro thread ("d.join()"),
esto no hace al programa más rapido.

Usar concurrencia dificulta mucho probar que un programa esta bien y puede llevar a muchos
bugs dificiles de reproducir, no se deberia usar al menos de estar seguros de que todos
los metodos invocados en el otro threas sean "thread safe". Además no sabemos si
crear un "deamon" es seguro en general, o en particular en Heroku.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants