Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getStreamForQuery spliterator does not have "ORDERED" characteristic #218

Open
maximilianpilz opened this issue Nov 12, 2024 · 0 comments
Open

getStreamForQuery spliterator does not have "ORDERED" characteristic #218

maximilianpilz opened this issue Nov 12, 2024 · 0 comments
Labels
bug Something isn't working synced Ticket has been synced to an internal issue tracker

Comments

@maximilianpilz
Copy link
Collaborator

The spliterator of streams returned from getStreamForQuery does not have the ORDERED characteristic, which is however expected for cases of ordering via queries.

Also getQueryResult adds the ORDERED characteristic on the one that does not have it, which seems to give a wrong impression about the true characteristics on this level.
@maximilianpilz maximilianpilz added the bug Something isn't working label Nov 12, 2024
@maximilianpilz maximilianpilz mentioned this issue Nov 12, 2024
Closed
18 tasks
@belagertem belagertem mentioned this issue Jan 23, 2025
Merged
12 tasks
maximilianpilz pushed a commit that referenced this issue Jan 27, 2025
@belagertem @ben-Draeger @midttuna
Add fix for the sequence id ordering problem (#233)
57a62a1 
Add the fix for the issue
[218](#218) from the [commit
](belagertem@729356b)
from the main branch.
Fix other queries in MessageStorage that require ordering.

# Checklist

The following aspects have been respected by the author of this pull
request, confirmed by both pull request assignee **and** reviewer:

* Adherence to coding conventions
  * [x] Pull Request Assignee
  * [x] Reviewer
* Adherence to javadoc conventions
  * [x] Pull Request Assignee
  * [x] Reviewer
* Changelog update (necessity checked and entry added or not added
respectively)
  * [x] Pull Request Assignee
  * [x] Reviewer
* README update (necessity checked and entry added or not added
respectively)
  * [x] Pull Request Assignee
  * [x] Reviewer
* config update (necessity checked and entry added or not added
respectively)
  * [x] Pull Request Assignee
  * [x] Reviewer
* SDCcc executable ran against a test device (if necessary)
  * [x] Pull Request Assignee
  * [x] Reviewer

---------

Signed-off-by: Malte Grebe-Lüth <[email protected]>
Co-authored-by: Björn <[email protected]>
Co-authored-by: midttuna <[email protected]>
@antipovi-draeger antipovi-draeger added the synced Ticket has been synced to an internal issue tracker label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working synced Ticket has been synced to an internal issue tracker
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maximilianpilz @antipovi-draeger