Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement list animation on TimetableTime and timetable items of FavoriteList. #824

Conversation

hiesiea
Copy link
Contributor

@hiesiea hiesiea commented Aug 27, 2024

Issue

Overview (Required)

  • Implement list animation on TimetableTime and timetable items of FavoriteList.
  • However, I have not been able to implement animation for my favorite items.

Links

  • none

Movie (Optional)

Before After
before.mp4
after.mp4

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 27, 2024 02:47 Inactive
@takahirom
Copy link
Member

Thank you for your pull request!
This is quite difficult, but could we implement an animation like a normal list? Currently, the animation is grouped by the start time.

Copy link

Detekt check failed. Please run ./gradlew detekt --auto-correct to fix the issues.

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 29, 2024 00:28 Inactive
@hiesiea
Copy link
Contributor Author

hiesiea commented Aug 29, 2024

This is quite difficult, but could we implement an animation like a normal list?

I have implemented it. However, the height of the TimetableTime was off or there were unwanted spaces in the list. I could not solve it.
a804801

@takahirom
Copy link
Member

@hiesiea Thank you. Could I have a movie for it? Also, please correct the formatting errors.

@hiesiea
Copy link
Contributor Author

hiesiea commented Aug 30, 2024

@takahirom

Could I have a movie for it?

This way.

after2.mp4

@github-actions github-actions bot temporarily deployed to deploygate-distribution August 30, 2024 00:35 Inactive
@takahirom
Copy link
Member

I think it is my fault, but the architecture of the item layout is not well-suited for animation 😇. I believe it is important to maintain consistency in animation. 🙇

@hiesiea
Copy link
Contributor Author

hiesiea commented Aug 30, 2024

Do you want to close this PR as further revisions are too severe for me?
Or do you want to revert the following commit?

@takahirom
Copy link
Member

takahirom commented Aug 30, 2024

Thanks. I want to create an animation similar to the default animation of a LazyColumn. Currently, our LazyColumn has items grouped together, resulting in a different animation than intended. I envision an animation where, when an item disappears, the next item smoothly slides up from below.

@hiesiea
Copy link
Contributor Author

hiesiea commented Sep 1, 2024

I want to create an animation similar to the default animation of a LazyColumn.

Sorry, but may I be removed from the assignment as it is too difficult for me?
And may I close this PR?

@takahirom
Copy link
Member

Sorry, I think it's my fault. However, I believe that animation consistency is important.

@takahirom takahirom closed this Sep 2, 2024
@hiesiea hiesiea deleted the feature/implement_list_animation_when_removing_favorite_on_favorites_screen branch September 2, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement List Animation When Removing Favorite on Favorites Screen
2 participants