Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Empty favorite screen's UI is slightly aligned towards the bottom #853

Open
Aniokrait opened this issue Aug 28, 2024 · 3 comments
Open

Empty favorite screen's UI is slightly aligned towards the bottom #853

Aniokrait opened this issue Aug 28, 2024 · 3 comments
Labels
contributions welcome difficulty:easy 🌱 priority:low 🐢 type: design enhancement 🎨

Comments

@Aniokrait
Copy link
Contributor

Overview

Empty view of the favorite screen is not aligned center vertically.
In figma, heart icon and following description is centered in whole screen (including header and navigation bar).

figma actual device
スクリーンショット 2024-08-28 22 31 24 Screenshot_20240828-222432

We need to subtract the offset for the header.
@Yamaton0827
Copy link
Contributor

🙋 I want to try it!

@raseln
Copy link
Contributor

raseln commented Sep 4, 2024

🤚

@Yamaton0827
Copy link
Contributor

#853 (comment)

I couldn't solve this issue.
I was able to move the Empty View a little bit upwards, but I couldn't move it to the center of the entire screen as Figma instructed.

Sorry, I will give up.

@Yamaton0827 Yamaton0827 mentioned this issue Sep 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
contributions welcome difficulty:easy 🌱 priority:low 🐢 type: design enhancement 🎨
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@takahirom @raseln @Yamaton0827 @Aniokrait