Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account Creation Form Issues #12

Open
Shadowfita opened this issue Dec 26, 2024 · 3 comments
Open

Account Creation Form Issues #12

Shadowfita opened this issue Dec 26, 2024 · 3 comments

Comments

@Shadowfita
Copy link

Hi,

Great project(s). Thank you very much for undertaking such a task.

I have just spun up my own instance and upon creating the admin account, am unable to use a non-typical domain suffix. It seems that every other letter makes it invalid. E.g., .tech domains.

Additionally, the username character requirement seems to be checking if it is greater than 5 characters, rather than equal to or greater than, as one would expect based on the input description.

Thanks again!

@DecDuck
Copy link
Contributor

DecDuck commented Dec 26, 2024

Thanks for the bug report!

We've patched the username issue just now on our develop branch (was just missing the = sign)

About the email issue - what emails were you trying? The validation regex doesn't specify any specific TLDs, it's just looking for:

[text]@[text].[text]

Did you perhaps have a space at the beginning or end?

@Shadowfita
Copy link
Author

Thanks for the bug report!

We've patched the username issue just now on our develop branch (was just missing the = sign)

About the email issue - what emails were you trying? The validation regex doesn't specify any specific TLDs, it's just looking for:

[text]@[text].[text]

Did you perhaps have a space at the beginning or end?

No spaces. For example: .com is valid, .au is not, and .tech is not.

Appreciate your prompt action!!

@DecDuck
Copy link
Contributor

DecDuck commented Dec 27, 2024

Hey! I figured out the issue. I had misunderstood what the g flag does to a RegEx in Javascript.

It's been fixed in the develop branch, and I can backport the fix to the main branch if you need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants