Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-write swReadLines methods to use C SOILWAT2 code instead of R code #97

Open
dschlaep opened this issue Jan 7, 2018 · 1 comment
Open

Re-write swReadLines methods to use C SOILWAT2 code instead of R code #97

dschlaep opened this issue Jan 7, 2018 · 1 comment
Labels
enhancement
Milestone
Clean code

Comments

@dschlaep
Copy link
Member

dschlaep commented Jan 7, 2018

swReadLines methods currently re-create functionality of C SOILWAT2-standalone code that reads inputs from files. This seems unnecessarily and hard to maintain.

Instead, rewrite swReadLines methods to (i) call C SOILWAT2-standalone functions to read inputs from file and (ii) call onGet_XXX functions to copy values from C global variables into R S4 class objects.
@dschlaep dschlaep added this to the Clean code milestone Jan 7, 2018
N1ckP3rsl3y pushed a commit that referenced this issue Jun 11, 2022
@dschlaep
Merge pull request #97 from Burke-Lauenroth-Lab/bugfix_92
fbf7764 
Bugfix 92: remove unused global variable
@dschlaep
Copy link
Member Author

dschlaep commented Jun 9, 2023

See commit e115d33 "getWeatherData_folders() now handles new daily weather inputs"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
Clean code
Development

No branches or pull requests
1 participant
@dschlaep