Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popup broken in Chrome with some locales (Italian) #1977

Closed
ghostwords opened this issue Apr 19, 2018 · 6 comments
Closed

Popup broken in Chrome with some locales (Italian) #1977

ghostwords opened this issue Apr 19, 2018 · 6 comments
Labels
bug Chrome help wanted translations ui User interface modifications; related to but not the same as the "ux" label

Comments

@ghostwords
Copy link
Member

ghostwords commented Apr 19, 2018

If I open the popup using messages from the Italian locale in Chrome (version 66), I see constant jumping but no content on pages with third-party domains to display in the popup. This may be a Chrome-specific bug.

screenshot from 2018-04-19 11 10 15

git bisect led me to 5a8d934 as the originating commit for this problem. Looks like changing min-width on body from 400 to 430 pixels did it.

What is it about our CSS that a width tweak can completely break rendering in some situations (longer locale strings? not clear yet what it is about the Italian locale).

@ghostwords ghostwords added bug ui User interface modifications; related to but not the same as the "ux" label Chrome translations labels Apr 19, 2018
@ghostwords ghostwords changed the title Popup broken in Chrome some locales (Italian) Popup broken in Chrome with some locales (Italian) Apr 19, 2018
@ghostwords
Copy link
Member Author

ghostwords commented Apr 20, 2018

It seems that the relevant message is popup_instructions. Both adding and subtracting characters seems to avoid the problem, so it's something about this particular message's exact length (and word spacing?).

English:
potential <a target='_blank' title='i18n_what_is_a_tracker' class='tooltip' href='https://www.eff.org/privacybadger#faq-What-is-a-third-party-tracker?'>trackers</a> on this page. These sliders let you control how Privacy Badger handles each one. You shouldn't need to adjust the sliders unless something is broken.

Italian:
potenziali <a target='_blank' title='i18n_what_is_a_tracker' class='tooltip' href='https://www.eff.org/privacybadger#faq-What-is-a-third-party-tracker?'>tracker</a> in questa pagina. Con questi pulsanti puoi controllare come Privacy Badger tratta ogni tracker. Non dovresti averne bisogno a meno che qualcosa non funzioni correttamente.

@ghostwords
Copy link
Member Author

It seems this Chrome bug has to do with the scrollbar. If popup_instructions is just the right length, Chrome seems to get confused and proceeds to continuously alternate between rendering the popup with and without a scrollbar.

@ghostwords
Copy link
Member Author

This is related to #1077 / #1113.

@ghostwords
Copy link
Member Author

From a CWS review:

su firefox nessun problema, su chrome in alcuni siti, quando clicco l'icona di PB, l'immagine vibra in modo insopportabile.

@ghostwords
Copy link
Member Author

Filed crbug.com/838150.

@ghostwords
Copy link
Member Author

Seems that changing body padding in bc231ec triggered this Chrome bug in the Italian locale. (5a8d934 is a followup commit that adjusts the width to account for border-box sizing; commits inbetween don't exhibit this issue because of greater body width.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Chrome help wanted translations ui User interface modifications; related to but not the same as the "ux" label
Projects
None yet
Development

No branches or pull requests

1 participant