Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the parameter overlap in kinematic feature extraction is misleading #12

Open
ELGarulli opened this issue Apr 11, 2024 · 0 comments
Open

the parameter overlap in kinematic feature extraction is misleading #12

ELGarulli opened this issue Apr 11, 2024 · 0 comments

Comments

@ELGarulli
Copy link
Owner

Since all the feat extraction are based on pd.rolling, overlap is treated as the step parameter. This leads to misleading behaviour of the parameter overlap.
Action: either change the name of the parameter, or correct to step = window-overlap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ELGarulli