Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdbuf -oL tee #3

Open
Gldkslfmsd opened this issue Oct 1, 2021 · 6 comments
Open

stdbuf -oL tee #3

Gldkslfmsd opened this issue Oct 1, 2021 · 6 comments
Assignees

Comments

@Gldkslfmsd
Copy link

Hello,

I noticed that tee is missing stdbuf in the output. Then, the pipeline stucks with no error after some time. Sometimes shortly after beginning, sometimes later.

I'm attaching 2 pipeline.sh scripts:
FIXED.sh.txt -- this one is fixed. I edited it to insert stdbufs. It never stucks.

This is a wrong, current piplener output. Stucks after some time.
WRONG.pipeline.sh.txt

Also, there there has to be stdbuf -o0 if the commands input and output is binary (it means 0 bytes buffer), and stdbuf -oL if it is text (1 full line buffer).
Maybe it would work with -o0 anytime, but I'm not sure.

@Gldkslfmsd
Copy link
Author

Gldkslfmsd commented Oct 1, 2021

./auto_switcher.py is an empty py script for now, I'm going to implement it.

@Gldkslfmsd Gldkslfmsd assigned Gldkslfmsd and srdecny and unassigned Gldkslfmsd Oct 1, 2021
@Gldkslfmsd
Copy link
Author

my.py.txt
This script is generating it.

@srdecny
Copy link
Member

srdecny commented Nov 15, 2021

@Gldkslfmsd Hi, sorry for the late response. I have pushed a fix to the main branch, can you please confirm it works for you now?

@Gldkslfmsd
Copy link
Author

Hi,
it's better, but there are still some tees without stdbuf:

stdbuf -oL nc -lk 5001 2> >(ts '[%Y-%m-%d %H:%M:%S]' > /pwd/logs/$DATE/00-cs_audio_rec.err) | tee >(while ! ss -ltn |

@Gldkslfmsd
Copy link
Author

I can't re-run the pipeline, it takes too much time to pull, restart the workers etc. I only looked at the code.
You can check cruise-control/pipeliner-setups/202109-dominik whether it runs for couple of minutes without stuck. If yes, then stdbuf might be the problem.
(Don't forget to remove the committed cruise-control/pipeliner-setups/202109-dominik/pipeliner.py with my simple temporary fix.)

@srdecny
Copy link
Member

srdecny commented Nov 16, 2021

Pushed another commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants