Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert t_sfc limiter #1188

Open
peverwhee opened this issue Nov 11, 2024 · 2 comments
Open

Revert t_sfc limiter #1188

peverwhee opened this issue Nov 11, 2024 · 2 comments
Assignees
@brian-eaton
Labels
misc tag issue or PR candidate for upcoming misc tag

Comments

@peverwhee
Copy link
Collaborator

Issue Type

Code Clean-up

Issue Description

Pending a CICE tag that will (hopefully) fix the bad values being passed to RRTMGP, we need to remove the limiter added to src/physics/rrtmgp/rrtmgp_inputs.F90 in #1184

   t_sfc = merge(t_sfc, tref_min, t_sfc > tref_min)
   t_sfc = merge(t_sfc, tref_max, t_sfc < tref_max)

Will this change answers?

I Don't Know

Will you be implementing this yourself?

Any CAM SE can do this
@peverwhee peverwhee added the misc tag issue or PR candidate for upcoming misc tag label Nov 11, 2024
@peverwhee
Copy link
Collaborator Author

@brian-eaton I'll move this up your priority list when the CICE tag is made. I'm hoping it can be part of a miscellaneous tag.

@peverwhee
Copy link
Collaborator Author

The PR for this should also have the "close" syntax for #1185

@peverwhee peverwhee mentioned this issue Nov 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brian-eaton brian-eaton

Labels
misc tag issue or PR candidate for upcoming misc tag
Projects
CAM Development
Status: To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brian-eaton @peverwhee