Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FATES_TRANSITIONS_MATRIX_LULU to FatesColdLUH2 testmods #2657

Closed
glemieux opened this issue Jul 23, 2024 · 2 comments · Fixed by #2594
Closed

Add FATES_TRANSITIONS_MATRIX_LULU to FatesColdLUH2 testmods #2657

glemieux opened this issue Jul 23, 2024 · 2 comments · Fixed by #2594
Assignees
@glemieux

Comments

@glemieux
Copy link
Collaborator

An initialization issue for FATES_TRANSITIONS_MATRIX_LULU was overlooked as I neglected to added this value to the user_nl_clm list with the ctsm API coinciding to NGEET/fates#1116

This probably is being missed in more tests that are based on the Fates testmod as history output is being cleared and this output is not added.

Originally posted by @glemieux in #2656 (comment)
@glemieux glemieux self-assigned this Jul 23, 2024
@glemieux
Copy link
Collaborator Author

@rgknox do you think adding a fix to this to #2594 would be alright given it relates to fates history output?

@glemieux glemieux mentioned this issue Jul 23, 2024
Closed
2 tasks
@glemieux
Copy link
Collaborator Author

On second thought, if I remember correctly, Fates is meant to be only 1D arrays, so this should really be added only to the FatesColdLUH2 tests mods.

@glemieux glemieux changed the title Add FATES_TRANSITIONS_MATRIX_LULU to Fates testmod Add FATES_TRANSITIONS_MATRIX_LULU to FatesColdLUH2 testmods Jul 23, 2024
@glemieux glemieux linked a pull request Jul 24, 2024 that will close this issue
fates history flushing #2594
Merged
@glemieux glemieux mentioned this issue Aug 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@glemieux glemieux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fates history flushing rgknox/ctsm
1 participant
@glemieux