Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offset for seconds is fixed to 5 #510

Open
Vrumfondel opened this issue Jan 15, 2025 · 4 comments
Open

Offset for seconds is fixed to 5 #510

Vrumfondel opened this issue Jan 15, 2025 · 4 comments

Comments

@Vrumfondel
Copy link

Offset for showing seconds is fixed to 5 pixles - which is only correct when using 40 pixles for seconds.
Better calculate from the used number of pixles.

@dbambus
Copy link
Collaborator

dbambus commented Jan 15, 2025

Hey @Vrumfondel,

i assume you mean the seconds for the frame :-) I will take a look into it.

Cheers
David

@Vrumfondel
Copy link
Author

Vrumfondel commented Jan 15, 2025

I guess it is in led.hpp:
const uint8_t offesetSecondsFrame = 5;

@dbambus
Copy link
Collaborator

dbambus commented Jan 15, 2025

Bingo :-)

But I ve to look at my wordclock how many LEDs I m using for my clock. Maybe a user changeable Offset would also be an option ?

@Vrumfondel
Copy link
Author

I propose to use
const uint8_t offesetSecondsFrame = usedUhrType->numPixelsFrameMatrix() / 8:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants