You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello, it would be nice having ther deploy_dir (deployDir) configurable per server because different servers could have different paths to web DocRoot. To get this benefit i made some changes in the code:
src/Deployer/DefaultDeployer.php:188 foreach ($appServers as $server) { $this->log(sprintf('<h3>Setting the %s property for <server>%s</> server</>', Property::deploy_dir, $server)); // BNEP modified: we want to set deploy_dir per server if not set with ->deployDir() if(empty(Property::deploy_dir)){ $server->set(Property::deploy_dir, $this->getConfig(Option::deployDir)); } } src/Configuration/DefaultConfiguration.php:364 protected function getReservedServerProperties(): array { return [Property::bin_dir, Property::config_dir, Property::console_bin, Property::cache_dir, /* ***BNEP modified: deploy_dir should be possible to set per server *** Property::deploy_dir, */ Property::log_dir, Property::src_dir, Property::templates_dir, Property::web_dir]; }
Maybe you could put that in master?
Regards
The text was updated successfully, but these errors were encountered:
Hello, it would be nice having ther deploy_dir (deployDir) configurable per server because different servers could have different paths to web DocRoot. To get this benefit i made some changes in the code:
src/Deployer/DefaultDeployer.php:188
foreach ($appServers as $server) { $this->log(sprintf('<h3>Setting the %s property for <server>%s</> server</>', Property::deploy_dir, $server)); // BNEP modified: we want to set deploy_dir per server if not set with ->deployDir() if(empty(Property::deploy_dir)){ $server->set(Property::deploy_dir, $this->getConfig(Option::deployDir)); } }
src/Configuration/DefaultConfiguration.php:364
protected function getReservedServerProperties(): array { return [Property::bin_dir, Property::config_dir, Property::console_bin, Property::cache_dir, /* ***BNEP modified: deploy_dir should be possible to set per server *** Property::deploy_dir, */ Property::log_dir, Property::src_dir, Property::templates_dir, Property::web_dir]; }
Maybe you could put that in master?
Regards
The text was updated successfully, but these errors were encountered: