Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeError: Cannot read property 'type' of undefined #142

Open
engineersamuel opened this issue Apr 19, 2021 · 4 comments
Open

TypeError: Cannot read property 'type' of undefined #142

engineersamuel opened this issue Apr 19, 2021 · 4 comments

Comments

@engineersamuel
Copy link

I have a valid Query that passes with tester.test however when I tester.mock with a fixture, then I'm seeing:

TypeError: Cannot read property 'type' of undefined
      at validateFixture (node_modules/easygraphql-tester/utils/fixture.js:50:27)
      at validateFixture (node_modules/easygraphql-tester/utils/fixture.js:100:19)

I debugged and it appears the issue is related to a simple name of type String which the mocker has no selectedType, hence the error at this line: https://github.com/EasyGraphQL/easygraphql-tester/blob/master/utils/fixture.js#L46

  if (schema[selectedType.type]) {

If I simply add a null check, all my tests pass:

  if (selectedType && schema[selectedType.type]) {

I'm happy to open a PR here, but I'd first want a core dev here to weigh in on what might be the issue and if this would be a valid check to simply add a null check on selectedType

@estrada9166
Copy link
Member

Thanks for creating this issue! can you share a quick example to reproduce it please! thanks!

@engineersamuel
Copy link
Author

@estrada9166 Sure thing, here it is: https://github.com/engineersamuel/easygraphqlrepro with instructions.

@estrada9166
Copy link
Member

Thanks for sharing it! what I can notice is that you are missing on the GraphQL schema, the field storageAccountName that is being tried to be mock

If you update it for - it may work

type StorageDirectory {
  name: String!
  storageAccountName: String!
  files(sampleSize: Int): [StorageFile]
}

Definitely something that can be improves is the error message in this case in case you want to open a PR!

@engineersamuel
Copy link
Author

Ahhh, great catch! Not sure on my bandwidth for a PR here, but let's leave this open and I'll try to get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants