Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTIONS] [INTERFACE] Trades feed should display notifications about items being added at store for buying or selling #22

Open
legionaw opened this issue Oct 21, 2020 · 6 comments
Labels
enhancement New feature or request

Comments

@legionaw
Copy link

As the title says, the Trades feed should also notify about items being added to buying/selling lists at stores.

@MonzUn
Copy link
Contributor

MonzUn commented Oct 22, 2020

That would be a neat and natural improvement!
I'm not sure this can be done via a mod. I'll need to look into how those messages are fired.

@MonzUn MonzUn self-assigned this Oct 22, 2020
@MonzUn MonzUn added enhancement New feature or request Investigate Look into this issue more to gain more information Minor A minor issue or improvement labels Oct 22, 2020
@MonzUn
Copy link
Contributor

MonzUn commented Dec 13, 2020

Investigated this today. Implementing this requires creating a callback from the server. I'll make a pull request to Eco in the future to enable this feature.

@MonzUn MonzUn removed the Investigate Look into this issue more to gain more information label Dec 13, 2020
@MonzUn MonzUn removed the Minor A minor issue or improvement label Feb 26, 2021
@Oskar1504
Copy link

Oskar1504 commented Feb 13, 2022

Wouldn't it be possible to store all tracked trades ( the store content) server side (bot) and run a cron job every 1h to check if something changed and send an update if so?

Isn't the best way and an callback would be much easier and resource-saving but it could work, couldn't it.

@MonzUn
Copy link
Contributor

MonzUn commented Feb 14, 2022

Yeah, but that's a hacky solution that has quite a few cases where it won't work.
If you want that solution, you're free to fork and run that fork on your server.

@Oskar1504
Copy link

Yeah, but that's a hacky solution that has quite a few cases where it won't work.
If you want that solution, you're free to fork and run that fork on your server.

Hey thanks for answering. I read the source code from this mod and im not able to write an solution myself. I thought you'd using some different approach my idea wasn't that usable for the environment u build. Sry fpr that i commented to fast.
I read some other mod source code to forward the eco sever data to api endpoints. (Cost Calculator mod already created recipe, player.. endpoints).

Bit still thanks for the answer. Great mod u developed.

@MonzUn
Copy link
Contributor

MonzUn commented Feb 14, 2022

You don't have to apologize, but I also don't understand what you mean. It's not related to any endpoints at all.

@MonzUn MonzUn removed their assignment Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants