-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Discord based server whitelisting #31
Comments
At its most basic this can be implemented by the user sending a command to the bot with their SLG ID, which the bot/mod would then be add the ID to the For example this is how the gaming community I am part of use a Discord bot for whitelisting on it's Squad game servers. What this does is provide a simple yet effective method of implementation, as the entre authentication process "should the user be allowed to whitelist?" is handled by preexisting external methods such as Patreon and Discord itself, while all the bot would do is provide the automation for it. For the purposes of Eco however there is likely going to be better/fancier ways to implement this such as using the account linking feature, however it would be a lot more complex and take a lot longer, so it might be worth focusing on a simpler solution just so the feature can actually exists, as it can always be improved upon in the future. |
Thanks for the feedback, but it seems you have misunderstood the problem a bit. The plugin would write to the config in memory, it would not with to files directly. This wouldn't work without restarts. The account linking feature already exists in the current public build. I'm not touching the problem of validating if a user should be allowed to whitelist at all. I'm also very much against making something hacky and trying to improve it later. |
Ah I was afraid that it wouldn't work without restarting though I shouldn't be surprised as that would of been too easy. By writing to the config in memory I assume you are opting for an approach similar to if a admin was to use a chat command while connected to the server to manage the whistelist as I assume that would be recognised straight away? The bit about authentication was just me thinking about how the entire process would work from start to finish from the user's perspective, though admittedly a chunk of that process (such as authentication) goes beyond the scope of what the mod is trying to do, and that you might end up including in different way. Regardless, I hope whatever the solution does not end up being too difficult to implement. |
Yeah it would work in a similar way. I think it will be quite a big feature that is going to be tricky to get both safe and easy to use. |
The text was updated successfully, but these errors were encountered: