Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move which depth/depth indices are read from code to config. #20

Open
BSchilperoort opened this issue Jul 8, 2022 · 0 comments
Open

Comments

@BSchilperoort
Copy link
Contributor

Currently the depths/depth indices that are read from the soil input data files are hardcoded in soil_io.py. These can be moved to a configuration file if desired so later.


See:

Let's move depths_indices = [0, 2, 4, 5, 6, 7] to prepare_soil_data and here consider it as an input argument to the function _read_soil_composition() as : _read_soil_composition(soil_data_path, lat, lon, depths_indices). We can add a ToDo to this module that the depths_indices can be read from config file.

Originally posted by @SarahAlidoost in #17 (comment)

Let's move depths = [0, 5, 30, 60, 100, 200] to prepare_soil_data and here consider it as an input argument to the function _read_hydraulic_parameters() as : _read_hydraulic_parameters(soil_data_path, lat, lon, depths). We can add a ToDo to this module that the depths can be read from config file.

Originally posted by @SarahAlidoost in #17 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant