Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for changing webservice url during runtime? #31

Open
anneferger opened this issue Nov 9, 2022 · 4 comments · Fixed by #59
Open

Allow for changing webservice url during runtime? #31

anneferger opened this issue Nov 9, 2022 · 4 comments · Fixed by #59
Assignees
Labels
feature for new client Good for newcomers

Comments

@anneferger
Copy link
Member

@peterstadler
Copy link
Member

Sounds like a plan :)
I found https://stackoverflow.com/questions/53010064/pass-environment-variable-into-a-vue-app-at-runtime which lists at least two options; the more hacky one (replacing strings in the js files with an entrypoint script) I've also seen (done) at https://github.com/TEIC/romajs/blob/dev/docker-entrypoint.sh

@anneferger anneferger changed the title Allow for changing webservice url? Allow for changing webservice url during runtime? Nov 14, 2022
@anneferger anneferger self-assigned this Nov 14, 2022
@anneferger
Copy link
Member Author

I thought some more about this, and I think what would be the easiest is to set the webservice_url variable to dev.meigarage.edirom.de when the action is running on the dev branch and not the main, see https://github.com/Edirom/vife-meigarage-webclient/tree/feature/set-webservice-url

  • we don't need to change the variable during runtime this way, only during build

@peterstadler
Copy link
Member

Yes, that will work for us – but still the build artifact ist tied to the deployment, hence it won't work for others (e.g. to be deployed at meigarage.example.com).

@anneferger
Copy link
Member Author

Yes, good point! We should still have this option

@anneferger anneferger reopened this Feb 10, 2023
@anneferger anneferger added the feature for new client Good for newcomers label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature for new client Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants