Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated timemory jsons #111

Open
glpuga opened this issue Oct 10, 2024 · 3 comments
Open

Truncated timemory jsons #111

glpuga opened this issue Oct 10, 2024 · 3 comments
Labels
bug Something isn't working needs-fix Bug confirmed, need a fix

Comments

@glpuga
Copy link
Collaborator

glpuga commented Oct 10, 2024

Bug description

Running 24hr bagfiles with timememory profiling on ends up with broken records because the recorded timememory output jsons get truncated and become unloadable.

Manually fixing them by emtying (not removing) the "history" section makes them usable again.

An untested solution may be to increase the sigterm and sigkill timeouts in ros2 launch

Platform (please complete the following information):

  • OS: [e.g. Ubuntu Focal]
  • Python version: [e.g. 3.8]
  • lambkin version: [e.g. tag, commit sha]

How to reproduce

List steps to reproduce the issue:

  1. ...

Code snippets or minimal examples are always helpful, if not necessary.

Expected behavior
A clear and concise description of what you expected to happen.

Actual behavior
A clear and concise description of what you actually happened.

Additional context

Any other information you think could be meaningful to this issue.

@glpuga glpuga added the bug Something isn't working label Oct 10, 2024
@hidmic hidmic added the needs-fix Bug confirmed, need a fix label Oct 24, 2024
@hidmic
Copy link
Collaborator

hidmic commented Oct 24, 2024

An untested solution may be to increase the sigterm and sigkill timeouts in ros2 launch

Yeah. It's brittle but it's an option. The actual solution would be for the profiler to do incremental writes to storage. Considering https://github.com/NERSC/timemory has been recently archived, perhaps there are other profiling tools we can use.

@glpuga
Copy link
Collaborator Author

glpuga commented Oct 28, 2024

The information we want from the json is actually volunteered by timememory in the on the standard output, can we get it form there instead?

@hidmic
Copy link
Collaborator

hidmic commented Oct 28, 2024

The information we want from the json is actually volunteered by timememory in the on the standard output, can we get it form there instead?

Memory might be failing me, but I think we did not do that because it made it hard to separate timem output from that of the underlying process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs-fix Bug confirmed, need a fix
Projects
None yet
Development

No branches or pull requests

2 participants