Fix rosdep install execution #115
Conversation
marcoshuck
requested review from
hidmic,
glpuga and
nahueespinosa
as code owners
Running rosdep update and rosdep install returns a permission denied error as described in #114. This prevented the release target to be executed. Adding a `rosdep fix-permissions` instruction to be run in sudo mode fixes the issue. Signed-off-by: Marcos Huck <[email protected]>
marcoshuck
force-pushed
the
marcoshuck/fix_ros_dep
branch
from
4239e28 to
70eae8e
Compare
Signed-off-by: Marcos Huck <[email protected]>
Signed-off-by: Marcos Huck <[email protected]>
Signed-off-by: Marcos Huck <[email protected]>
Signed-off-by: Marcos Huck <[email protected]>
Signed-off-by: Marcos Huck <[email protected]>
src/external/os/Earthfile
Outdated
| FUNCTION | ||
| ARG user | ||
| ARG workdir=/home/${user} | ||
| RUN rosdep fix-permissions |
There was a problem hiding this comment.
@marcoshuck have you tried this out? Where is a workdir used? I would've expected rosdep to require sudo
There was a problem hiding this comment.
I ended up rewriting the code in this function and forgot to remove the workspace, I ran the whole build and it seemed to have worked as intended, can try running it again from scratch to double check (but it would be nice if we have CI at some point)
There was a problem hiding this comment.
+1 to adding CI in a follow-up, never got around to do it.
There was a problem hiding this comment.
I re-ran the whole build without the layer cache and without sudo, it built the image as intended.
There was a problem hiding this comment.
Not sure if it's worth removing rosdep fix-permissions, since we changed the base, the issue was probably fixed somewhere else.
Signed-off-by: Marcos Huck <[email protected]>
Signed-off-by: Marcos Huck <[email protected]>
Signed-off-by: Marcos Huck <[email protected]>
Co-authored-by: Michel Hidalgo <[email protected]> Signed-off-by: Marcos Huck <[email protected]>
marcoshuck
force-pushed
the
marcoshuck/fix_ros_dep
branch
from
36a00b7 to
8a27cbe
Compare
Proposed changes
Running rosdep update and rosdep install returns a permission denied error as described in #114. This prevented the release target to be executed.
Adding a
rosdep fix-permissionsinstruction to be run in sudo mode fixes the issue.Type of change
💥 Breaking change! Explain why a non-backwards compatible change is necessary or remove this line entirely if not applicable.
Checklist
Put an
xin the boxes that apply. This is simply a reminder of what we will require before merging your code.Additional comments
Fix #114