Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ENABLE_OVERRIDE #5

Open
repi opened this issue Nov 5, 2019 · 2 comments
Open

Add support for ENABLE_OVERRIDE #5

repi opened this issue Nov 5, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@repi
Copy link
Contributor

repi commented Nov 5, 2019

To enable rpmalloc's overriding of C malloc/free functions, this enables rpmalloc to be used instead of the system allocator for C/C++ code dependencies as well, not just for Rust code.

Easy to enable (and should be a feature flag on the crates) but do have to make sure it links properly on all platforms and targets.

@repi repi added enhancement New feature or request help wanted Extra attention is needed labels Nov 5, 2019
@mjansson
Copy link

mjansson commented Nov 9, 2019

One caveat is that symbol replacing on Windows platforms is a proper pain and not currently implemented in rpmalloc (code for it can be found in the tcmalloc container project, gperftools, but it's quite nasty).

@repi
Copy link
Contributor Author

repi commented Nov 9, 2019

Thanks for the heads up! Could see that being messy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants