Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.6 causes my 1.19.2 server to not start #46

Closed
ChristopherHaws opened this issue Dec 10, 2022 · 5 comments
Closed

0.3.6 causes my 1.19.2 server to not start #46

ChristopherHaws opened this issue Dec 10, 2022 · 5 comments

Comments

@ChristopherHaws
Copy link

After updating to 0.3.6 my server no longer starts. Downgrading back to 0.3.5 fixes the issue.

Here are my server logs:
https://mclo.gs/q9mFMtE

@gniftygnome
Copy link

class_1132 is net/minecraft/server/integrated/IntegratedServer so this is probably a missed guard against doing integrated server stuff when running on a multiplayer server. I've got basically the same error with a very different set of mods.

@gniftygnome
Copy link

Oh, it's an instanceof call.

        Syncmatica.initServer(
                new ServerCommunicationManager(),
                new FileStorage(),
                new SyncmaticManager(),
                returnValue instanceof IntegratedServer,
                returnValue.getSavePath(WorldSavePath.ROOT).toFile()
        ).startup();

I think in 1.19+ at least it's intended to use !returnValue.isDedicated() rather than returnValue instanceof IntegratedServer although I've not needed to check dedicated vs. integrated before.

@nnnik
Copy link
Member

nnnik commented Dec 13, 2022

Thank you for this report I will try to fix

@nnnik nnnik pinned this issue Dec 13, 2022
@nnnik nnnik unpinned this issue Dec 13, 2022
@nnnik
Copy link
Member

nnnik commented Dec 13, 2022

That seems to be indeed the problem. 1.19 makes the DedicatedServer class client only.
isDedicated is indeed what I want here.

@nnnik nnnik pinned this issue Dec 13, 2022
@nnnik nnnik unpinned this issue Dec 13, 2022
@nnnik nnnik pinned this issue Dec 13, 2022
@nnnik
Copy link
Member

nnnik commented Dec 13, 2022

I apologize for the delay on this one - I have setup webhooks to the Discord now to get notified of issues like these quicker.
Please check out the latest releases for a fix.
https://github.com/End-Tech/syncmatica/releases/tag/v0.3.7-1.16.5

@nnnik nnnik closed this as completed Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants