Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG #71

Open
bunnyi116 opened this issue Apr 9, 2024 · 4 comments
Open

BUG #71

bunnyi116 opened this issue Apr 9, 2024 · 4 comments

Comments

@bunnyi116
Copy link
Contributor

I found that after uploading, unlocking, and then deleting, when using Syncmatica to load, the lock button cannot be unlocked.

Unlock

111

Remove

222

Unload

333

Load

444

Cannot be unlocked

555

@sakura-ryoko
Copy link

I would suggest enabling the packet logging to see if it's getting a MODIFY DENIED packet

@sakura-ryoko
Copy link

Also, I have a bit of a hard time following the images due to the translation :)

@bunnyi116
Copy link
Contributor Author

This is because when a user unlocks for adjustments, the server should set a status that prevents other users from taking further actions. Only after the player completes and locks the changes can other users unlock for actions.

Solution: When a player unlocks and deletes/unloads the schematic, or exits the game, they should send data to update the status.

@nnnik
Copy link
Member

nnnik commented Apr 9, 2024

A client logging off should have the same effect as them sending an abort modification packet.
A client unloading a local placement should also abort or alternatively the server should send the client the state of the modification when loading the placement again.
Regardless there should be a timeout on the placement modification of maybe like 5 minutes (And probably all other exchanges should have timeouts too).
This currently is an oversight in the business logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants