Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sponge] 1.21.4 #2687

Merged
merged 2 commits into from
Jan 5, 2025
Merged

[Sponge] 1.21.4 #2687

merged 2 commits into from
Jan 5, 2025

Conversation

me4502
Copy link
Member

@me4502 me4502 commented Dec 30, 2024

Updates the Sponge platform for 1.21.4.

@me4502 me4502 marked this pull request as ready for review December 30, 2024 11:52
@me4502 me4502 requested a review from a team as a code owner December 30, 2024 11:52
@me4502
Copy link
Member Author

me4502 commented Jan 2, 2025

@avaruus1 hi, just tagging you as you re-added the Sponge module back and are likely more familiar with it. is there anything that i should be mindful of in the API 14 migration here? everything aside from the MethodHandles stuff seemed to just compile fine, and it worked from some light testing.

@me4502 me4502 added this to the 7.3.10 milestone Jan 3, 2025
@avaruus1
Copy link
Contributor

avaruus1 commented Jan 3, 2025

@avaruus1 hi, just tagging you as you re-added the Sponge module back and are likely more familiar with it. is there anything that i should be mindful of in the API 14 migration here? everything aside from the MethodHandles stuff seemed to just compile fine, and it worked from some light testing.

AFAIK API-14 has no breaking changes that would affect WorldEdit.

@me4502
Copy link
Member Author

me4502 commented Jan 5, 2025

cool, thanks for clarifying :)

@me4502 me4502 enabled auto-merge (squash) January 5, 2025 11:56
@me4502 me4502 merged commit 805bde1 into version/7.3.x Jan 5, 2025
5 checks passed
@me4502 me4502 deleted the chore/sponge-1.21.4 branch January 5, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants