Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix price for d2l items named "Genuine Genuine ..." #6

Open
Enygma2002 opened this issue Mar 23, 2015 · 2 comments
Open

Fix price for d2l items named "Genuine Genuine ..." #6

Enygma2002 opened this issue Mar 23, 2015 · 2 comments
Labels

Comments

@Enygma2002
Copy link
Owner

D2L badly displays some genuine items, naming them "Genuine Genuine ". This makes the price fetching code fail and badly display the item as "Not Marketable"

Example:
Screenshot of "Genuine Genuine" appearing in the item's name

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@Enygma2002 Enygma2002 added the bug label Mar 23, 2015
@ncla
Copy link

ncla commented Mar 24, 2015

You should change getItemName method anyway to read the alt attribute from img element, just like we do it on LoungeDestroyer :)

Not sure if this will fix this specific case but this is better, more consistent way to get item market name.

@Enygma2002
Copy link
Owner Author

@ncla That sounds like a pretty good suggestion!

I will probably use it as the main method, but also fallback on the current method, just in case d2l changes stuff again.

Thanks!

Repository owner deleted a comment from LeonardoWlopes Feb 23, 2024
Repository owner deleted a comment from roneyfraga Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants
@Enygma2002 @ncla and others