Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[calcite-tile]: Preserve icon sizing of tile with description when there is no description prop provided #11376

Open
2 of 6 tasks
jasdelreyes opened this issue Jan 24, 2025 · 2 comments
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. has workaround Issues have a workaround available in the meantime. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone needs triage Planning workflow - pending design/dev review.

Comments

@jasdelreyes
Copy link

Check existing issues

Description

Here's a thread explaining the current behavior: https://teams.microsoft.com/l/message/19:[email protected]/1737663288766?tenantId=aee6e3c9-711e-4c7c-bd27-04f2307db20d&groupId=56fae21a-9407-4943-859f-a9bfcf0bbad3&parentMessageId=1737663288766&teamName=Calcite%20Design%20System&channelName=Get%20Help%20-%20Design%20and%20Figma&createdTime=1737663288766

Essentially, I want the icon of a calcite-tile to not automatically enlarge when no description prop is provided.

Acceptance Criteria

Provide an opt in option so that the icon size does not automatically enlarge when no description prop is provided. Here's a link to a design to get a sense of the vision: https://devtopia.esri.com/WebGIS/arcgis-app-components/issues/9454#issue-1957588.

I would like the icon size to stay small like:
Image with no description prop provided.

Relevant Info

No response

Which Component

calcite-tile

Example Use Case

No response

Priority impact

impact - p1 - need for current milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online

@jasdelreyes jasdelreyes added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Jan 24, 2025
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Jan 24, 2025
@macandcheese macandcheese added the design Issues that need design consultation prior to development. label Jan 24, 2025
@eriklharper
Copy link
Contributor

Related: #10124

@eriklharper
Copy link
Contributor

This automatic icon enlargement behavior is planned for deprecation, as it was a part of the initial design for Tile known as "Large Visual". Because it has been around so long, it would be considered a breaking change to either make it opt-in or remove it entirely, and we overlooked it as part of the 3.0 breaking changes.

The workaround is to use the content-top slot with a calcite-icon element in place of the icon property.

Here's an updated codepen showing that: https://codepen.io/eriklharper/pen/qEWQmGN?editors=1000

@eriklharper eriklharper added the has workaround Issues have a workaround available in the meantime. label Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Online Issues logged by ArcGIS Online team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. has workaround Issues have a workaround available in the meantime. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants