Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Block] - Always show the collapse / expand chevron #4935

Closed
macandcheese opened this issue Jul 14, 2022 · 12 comments
Closed

[Block] - Always show the collapse / expand chevron #4935

macandcheese opened this issue Jul 14, 2022 · 12 comments
Assignees
@geospatialem @SkyeSeitz @ashetland @brittneytewks
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. low risk Issues with low risk for consideration in low risk milestones p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Milestone
2023 October Prio...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented Jul 14, 2022 •
edited
Loading

Description

We received feedback that hiding the chevron open / close affordance when actions are slotted into a block can be confusing as the indicator is not present.

Acceptance Criteria

The chevron showing collapse / expand is always visible, whether or not items are slotted into block.

Relevant Info

cc @asangma

Which Component

Block

Example Use Case

When there is a slotted action / control in the block, the caret disappears and can obfuscate the open / close functionality.
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jul 14, 2022
@macandcheese macandcheese added the design Issues that need design consultation prior to development. label Mar 20, 2023
@avezina
Copy link

avezina commented May 31, 2023

We use the calcite-block in the UtilityNetworkTrace widget in different places.

In the Inputs panel, blocks display the chevron to indicate the block can be expanded and collapsed.
image
In the Results panel, We also use a collapsible so users can expand and collapse result sections, but in this case, a slotted action providing more options is present and the chevron cannot be shown. Users will not be aware that these sections can be collapsed to make it easier for them to explore the results.
image

Sample: https://codepen.io/avezina/pen/jOYdLwW username: viewer01 password: I68VGU^nMurF

@geospatialem geospatialem added the ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. label May 31, 2023
@macandcheese
Copy link
Contributor Author

Cc @SkyeSeitz / @ashetland

@ashetland ashetland added the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label May 31, 2023
@ashetland
Copy link
Contributor

Yep, in general agreement here. Any thoughts on priority?

@geospatialem
Copy link
Member

@ashetland Do we think we could tackle in the next two months so we could complete the dev work by September, so folks can update for the upcoming R3 release this fall?

@geospatialem geospatialem added the p - medium Issue is non core or affecting less that 60% of people using the library label May 31, 2023
@avezina
Copy link

avezina commented May 31, 2023

I think this is also more importantly needed for UtilityNetworkAssociations widget
image
image

I would say medium priority for an optional chevron.

@ashetland
Copy link
Contributor

@ashetland Do we think we could tackle in the next two months so we could complete the dev work by September, so folks can update for the upcoming R3 release this fall?

Yep. Adding to sprint planning.

@ashetland ashetland added this to the Design Sprint Planning milestone May 31, 2023
@ashetland ashetland removed the needs triage Planning workflow - pending design/dev review. label May 31, 2023
@macandcheese
Copy link
Contributor Author

To avoid “hitbox hopscotch ™️”, I think the chevron should be placed adjacent to the heading / description at all times and not at the extent of the block, so there’s one interactive element to expand / collapse. We may need to adjust some padding.

Cc @asangma - remember this one 🙃?

@geospatialem geospatialem added p - high Issue should be addressed in the current milestone, impacts component or core functionality and removed p - medium Issue is non core or affecting less that 60% of people using the library labels Jun 27, 2023
@geospatialem
Copy link
Member

Moving to the next design sprint due to multiple +1's above, and the Teams conversation on 6/27. cc @ashetland @SkyeSeitz

@macandcheese macandcheese changed the title [Block] - Re-evaluate hiding the open / close icon when action-end / slotted [Block] - Always show the collapse / expand caret Jun 27, 2023
@macandcheese macandcheese changed the title [Block] - Always show the collapse / expand caret [Block] - Always show the collapse / expand chevron Jun 27, 2023
@ashetland ashetland mentioned this issue Jun 29, 2023
Closed
@ashetland ashetland added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jun 30, 2023
@ashetland ashetland added the ready for dev Issues ready for development implementation. label Aug 7, 2023
@github-actions github-actions bot added 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Aug 7, 2023
@github-actions github-actions bot removed this from the Design Sprint milestone Aug 7, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 7, 2023

cc @geospatialem, @brittneytewks

@SkyeSeitz SkyeSeitz mentioned this issue Aug 9, 2023
Closed
3 tasks
@macandcheese macandcheese mentioned this issue Aug 15, 2023
Closed
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 6, 2023
@brittneytewks brittneytewks added the low risk Issues with low risk for consideration in low risk milestones label Sep 21, 2023
@jcfranco jcfranco self-assigned this Oct 14, 2023
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Oct 14, 2023
@jcfranco jcfranco mentioned this issue Oct 14, 2023
Merged
jcfranco added a commit that referenced this issue Oct 17, 2023
@jcfranco
feat(block): ensure chevron is always displayed (#8014)
95fecb2 
**Related Issue:** #4935 

## Summary

Toggle icon is now always visible.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Oct 17, 2023
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 25, 2023
@geospatialem
Copy link
Member

Verified in 1.10.0-next.7 with https://codepen.io/geospatialem/pen/VwgLVZQ

verify-4935

@ashetland ashetland removed the figma changes Issues that require additions or updates to the Figma UI Kit where no `design` label exists label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@SkyeSeitz SkyeSeitz

@ashetland ashetland

@brittneytewks brittneytewks

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. low risk Issues with low risk for consideration in low risk milestones p - high Issue should be addressed in the current milestone, impacts component or core functionality ready for dev Issues ready for development implementation.
Projects
None yet
Milestone
2023 October Priorities - Maintenance...
Development

No branches or pull requests
8 participants
@jcfranco @alisonailea @macandcheese @geospatialem @SkyeSeitz @avezina @ashetland @brittneytewks