From 45fa6b4eca6ed5b764852e83fe46d74db51c72df Mon Sep 17 00:00:00 2001 From: Kitty Hurley Date: Wed, 12 Feb 2025 13:27:03 -0600 Subject: [PATCH 1/2] docs(loader): update references to reflect component use --- .../src/components/loader/loader.scss | 14 +++++++------- .../src/components/loader/loader.tsx | 4 ++-- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/calcite-components/src/components/loader/loader.scss b/packages/calcite-components/src/components/loader/loader.scss index d040dce5314..92d463fa8c0 100644 --- a/packages/calcite-components/src/components/loader/loader.scss +++ b/packages/calcite-components/src/components/loader/loader.scss @@ -3,15 +3,15 @@ * * These properties can be overridden using the component's tag as selector. * - * @prop --calcite-loader-font-size: Specifies the font size of the loading percentage when type is `"determinate"`. - * @prop --calcite-loader-size: Specifies the width and height of the component when not set to inline. + * @prop --calcite-loader-font-size: When `type` is not `"indeterminate"`, specifies the font size of the loading percentage. + * @prop --calcite-loader-size: When `inline` is not set, specifies the component's width and height. * @prop --calcite-loader-size-inline: [Deprecated] Use `--calcite-loader-size`. Specifies the width and height of the component when set to inline. * @prop --calcite-loader-spacing: Specifies the the component's padding. - * @prop --calcite-loader-progress-color-inline: Specifies the width and height of the component when set to inline. - * @prop --calcite-loader-text-spacing: Specifies the component's text margin. - * @prop --calcite-loader-text-weight: Specifies the component's font weight. - * @prop --calcite-loader-text-color: Specifies the component's text color. - * @prop --calcite-loader-progress-color: Specifies the component's progress ring color. + * @prop --calcite-loader-progress-color-inline: When `inline`, specifies the component's progress ring color. + * @prop --calcite-loader-text-spacing: When not `inline`, specifies the component's `text` margin. + * @prop --calcite-loader-text-weight: When not `inline` and `text` is provided, specifies the component's `text` font weight. + * @prop --calcite-loader-text-color: When not `inline` and `text` is provided, specifies the component's `text` color. + * @prop --calcite-loader-progress-color: When not `inline`, specifies the component's progress ring color. * @prop --calcite-loader-track-color: Specifies the component's track color. */ diff --git a/packages/calcite-components/src/components/loader/loader.tsx b/packages/calcite-components/src/components/loader/loader.tsx index c9bb2b33b37..283f7fcd73c 100644 --- a/packages/calcite-components/src/components/loader/loader.tsx +++ b/packages/calcite-components/src/components/loader/loader.tsx @@ -37,7 +37,7 @@ export class Loader extends LitElement { */ @property({ reflect: true }) complete = false; - /** When `true`, displays smaller and appears to the left of the text. */ + /** When `true`, the component displays smaller. */ @property({ reflect: true }) inline = false; /** @@ -50,7 +50,7 @@ export class Loader extends LitElement { /** Specifies the size of the component. */ @property({ reflect: true }) scale: Scale = "m"; - /** Text that displays under the component's indicator. */ + /** When not `inline`, displays text under the component's indicator. */ @property() text = ""; /** From ae3c3182495d1ddc35922b63d705811e1639e0aa Mon Sep 17 00:00:00 2001 From: Kitty Hurley Date: Wed, 12 Feb 2025 14:57:27 -0600 Subject: [PATCH 2/2] update --calcite-loader-font-size description --- packages/calcite-components/src/components/loader/loader.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/calcite-components/src/components/loader/loader.scss b/packages/calcite-components/src/components/loader/loader.scss index 92d463fa8c0..6f53b45035d 100644 --- a/packages/calcite-components/src/components/loader/loader.scss +++ b/packages/calcite-components/src/components/loader/loader.scss @@ -3,7 +3,7 @@ * * These properties can be overridden using the component's tag as selector. * - * @prop --calcite-loader-font-size: When `type` is not `"indeterminate"`, specifies the font size of the loading percentage. + * @prop --calcite-loader-font-size: When `type` is not `"indeterminate"` or `inline`, specifies the font size of the loading percentage. * @prop --calcite-loader-size: When `inline` is not set, specifies the component's width and height. * @prop --calcite-loader-size-inline: [Deprecated] Use `--calcite-loader-size`. Specifies the width and height of the component when set to inline. * @prop --calcite-loader-spacing: Specifies the the component's padding.