Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universally render Modi Script with webfonts #1103

Open
ksinkar opened this issue Jul 3, 2022 · 2 comments
Open

Universally render Modi Script with webfonts #1103

ksinkar opened this issue Jul 3, 2022 · 2 comments
Assignees

Comments

@ksinkar
Copy link
Contributor

ksinkar commented Jul 3, 2022

If the script is not rendered properly on your computer, please download the font from here: https://fonts.google.com/noto/specimen/Noto+Sans+Modi

The font rendered properly in macOS for me, but I ran into this issue when checking out the new translation from a Windows 10 machine. It looks like we can package the font as a web font, so it may be possible to render the page for all users without having to manually download a font. We'd have to see if hugo can handle a remote font download and apply it for just this page. An alternative is to add a note to the top or bottom of the translation to download the font if the page doesn't render properly.

I don't think this should block merging, but it's something to keep in mind to fix up later.

Originally posted by @klaude in #1051 (comment)

@ksinkar
Copy link
Contributor Author

ksinkar commented Jul 3, 2022

@CoralineAda Could you please assign this issue to me?

@CoralineAda CoralineAda assigned CoralineAda and ksinkar and unassigned CoralineAda Jul 6, 2022
ksinkar added a commit to ksinkar/contributor_covenant that referenced this issue Sep 8, 2022
@ksinkar
Copy link
Contributor Author

ksinkar commented Oct 4, 2022

@klaude @CoralineAda I have raised a PR for resolving this issue. Please have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@CoralineAda @ksinkar and others