Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecosystem map lines #987

Closed
ferrisoxide opened this issue Aug 9, 2024 · 4 comments
Closed

Ecosystem map lines #987

ferrisoxide opened this issue Aug 9, 2024 · 4 comments
Assignees
Labels
Milestone

Comments

@ferrisoxide
Copy link
Collaborator

ferrisoxide commented Aug 9, 2024

Describe the bug

As reported by @emily-humphreys

When a node in the ecosystem map is double-clicked to highlight itself and its connected nodes, the lines connecting other nodes that are not in focus (i.e. not connected to the selected node) are set to a light grey.

This is intentional, as it makes the selected nodes and their connections (drawn in green) easier to see and deemphasises the nodes the are not selected.

However, once a node has been selected this way it is impossible to return the graph back to the original state. Clicking on another node, or elsewhere on the page, doesn't help as there will always be a set of selected nodes.

The solution might be to allow for an "unselect" the connected nodes if the central node is double-clicked a second time. The expectation would be that double-clicking would remove the green highlight and return the graph to its former state.

As an aside the z-order of lines is unrelated to the highlighted status. As a consequence, when there are large numbers of nodes, the light grey lines can criss-cross the highlighted lines, obscuring their selected status.

Screenshots

Image 1 - when it first loads (dark grey lines)

unnamed

Image 2 - double click a node

unnamed
(Lines turn light grey and green connections albeit in this map a little tricky to see)

Image 3 - after you’ve double clicked out of that (see lines stay light grey - would be great if they returned back to dark grey)

unnamed

@SishaMish
Copy link
Collaborator

Related to #960

@ferrisoxide ferrisoxide added this to the Gen 2 milestone Aug 25, 2024
@ferrisoxide ferrisoxide removed the gen 2 label Aug 25, 2024
@ferrisoxide ferrisoxide self-assigned this Feb 22, 2025
@ferrisoxide ferrisoxide moved this from Scheduled to In progress in Tool for Systemic Change Feb 22, 2025
@ferrisoxide
Copy link
Collaborator Author

NOTES TO QA

The main issue here was that there was no way to "deselect" the selected nodes. Now, if you click on the graph anywhere there are no nodes, the graph line colours will reset.

NB there is an issue with the stakeholder network not highlighting the actual nodes (thematic map does) - only the lines between nodes get highlighted. We'll deal with that separately.

@ferrisoxide
Copy link
Collaborator Author

@SishaMish This is on staging and ready for QA.

@ferrisoxide ferrisoxide moved this from In progress to Ready for QA in Tool for Systemic Change Feb 22, 2025
@SishaMish
Copy link
Collaborator

SishaMish commented Feb 23, 2025

@ferrisoxide

QA'd and passed

Found another issue with the names of the nodes staying in the highlight colour after deselecting the lines. Will create a new ticket for this issue #1127

👍

@SishaMish SishaMish moved this from Ready for QA to Done in Tool for Systemic Change Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants