-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Добавлен флаг Nagle в TCP соединение #1393
Conversation
Обзор измененийИзменения касаются класса TCPClient в стандартной библиотеке OneScript, где свойство Изменения
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (3)
- src/1Script.sln (3 hunks)
- src/OneScript.StandardLibrary/Net/TCPClient.cs (1 hunks)
- src/UpgradeLog2.htm (1 hunks)
Files not summarized due to errors (1)
- src/1Script.sln: Error: Message exceeds token limit
Additional comments: 3
src/OneScript.StandardLibrary/Net/TCPClient.cs (2)
- 166-174: Добавлено свойство
NoDelay
, которое позволяет управлять алгоритмом Нейгла для TCP соединения. Убедитесь, что это изменение документировано в соответствующих местах, таких как README или документация API.- 166-174: Изменение свойства
ReadTimeout
для добавления сеттера выглядит корректным.src/UpgradeLog2.htm (1)
- 1-294: Общий обзор файла не выявил других проблем, кроме указанных выше. Структура HTML и стили CSS кажутся стандартными для шаблона отчета.
<!DOCTYPE html> | ||
<!-- saved from url=(0014)about:internet --> | ||
<html xmlns:msxsl="urn:schemas-microsoft-com:xslt"><head><meta content="en-us" http-equiv="Content-Language" /><meta content="text/html; charset=utf-16" http-equiv="Content-Type" /><title _locID="ConversionReport0"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Кодировка документа указана как UTF-16, что может быть несовместимо с некоторыми браузерами или серверами, которые ожидают UTF-8 по умолчанию.
- <meta content="text/html; charset=utf-16" http-equiv="Content-Type" />
+ <meta content="text/html; charset=utf-8" http-equiv="Content-Type" />
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
<!DOCTYPE html> | |
<!-- saved from url=(0014)about:internet --> | |
<html xmlns:msxsl="urn:schemas-microsoft-com:xslt"><head><meta content="en-us" http-equiv="Content-Language" /><meta content="text/html; charset=utf-16" http-equiv="Content-Type" /><title _locID="ConversionReport0"> | |
<!DOCTYPE html> | |
<!-- saved from url=(0014)about:internet --> | |
<html xmlns:msxsl="urn:schemas-microsoft-com:xslt"><head><meta content="en-us" http-equiv="Content-Language" /><meta content="text/html; charset=utf-8" http-equiv="Content-Type" /><title _locID="ConversionReport0"> |
} | ||
} | ||
} | ||
|
||
function scrollToFirstVisibleRow(name) | ||
{ | ||
var allRows = document.getElementsByTagName('tr'); | ||
for (i=0; i < allRows.length; i++) | ||
{ | ||
var currentName = allRows[i].getAttribute('name'); | ||
var isVisible = allRows[i].style.display == ''; | ||
if(!!currentName && currentName.indexOf(name) == 0 && isVisible) | ||
{ | ||
allRows[i].scrollIntoView(true); | ||
return true; | ||
} | ||
} | ||
|
||
return false; | ||
} | ||
|
||
// Linkifies the specified text content, replaces candidate links with html links | ||
function linkify(text) | ||
{ | ||
if(!text || 0 === text.length) | ||
{ | ||
return text; | ||
} | ||
|
||
// Find http, https and ftp links and replace them with hyper links | ||
var urlLink = /(http|https|ftp)\:\/\/[a-zA-Z0-9\-\.]+(:[a-zA-Z0-9]*)?\/?([a-zA-Z0-9\-\._\?\,\/\\\+&%\$#\=~;\{\}])*/gi; | ||
|
||
return text.replace(urlLink, '<a href="$&">$&</a>') ; | ||
} | ||
|
||
// Linkifies the specified element by ID | ||
function linkifyElement(id) | ||
{ | ||
var element = document.getElementById(id); | ||
if(!!element) | ||
{ | ||
element.innerHTML = linkify(element.innerHTML); | ||
} | ||
} | ||
|
||
function ToggleMessageVisibility(projectName) | ||
{ | ||
if(!projectName || 0 === projectName.length) | ||
{ | ||
return; | ||
} | ||
|
||
toggleTableRowsByName("MessageRowClass" + projectName); | ||
toggleTableRowsByName('MessageRowHeaderShow' + projectName); | ||
toggleTableRowsByName('MessageRowHeaderHide' + projectName); | ||
} | ||
|
||
function ScrollToFirstVisibleMessage(projectName) | ||
{ | ||
if(!projectName || 0 === projectName.length) | ||
{ | ||
return; | ||
} | ||
|
||
// First try the 'Show messages' row | ||
if(!scrollToFirstVisibleRow('MessageRowHeaderShow' + projectName)) | ||
{ | ||
// Failed to find a visible row for 'Show messages', try an actual message row | ||
scrollToFirstVisibleRow('MessageRowClass' + projectName); | ||
} | ||
} | ||
</script></head><body><h1 _locID="ConversionReport"> | ||
Отчет о миграции - </h1><div id="content"><h2 _locID="OverviewTitle">Обзор</h2><div id="overview"><table><tr><th></th><th _locID="ProjectTableHeader">Проект</th><th _locID="PathTableHeader">Путь</th><th _locID="ErrorsTableHeader">Ошибки</th><th _locID="WarningsTableHeader">Предупреждения</th><th _locID="MessagesTableHeader">Сообщения</th></tr><tr><td class="IconErrorEncoded" /><td><strong><a href="#Installer">Installer</a></strong></td><td>Installer\Installer.wixproj</td><td class="textCentered"><a href="#InstallerError">1</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#AddInNative">AddInNative</a></strong></td><td>..\tests\native-api\AddInNative.vcxproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#Component">Component</a></strong></td><td>Component\Component.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScript.Core">OneScript.Core</a></strong></td><td>OneScript.Core\OneScript.Core.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScript.Core.Tests">OneScript.Core.Tests</a></strong></td><td>Tests\OneScript.Core.Tests\OneScript.Core.Tests.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScript.DebugProtocol">OneScript.DebugProtocol</a></strong></td><td>OneScript.DebugProtocol\OneScript.DebugProtocol.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScript.DebugProtocol.Test">OneScript.DebugProtocol.Test</a></strong></td><td>Tests\OneScript.DebugProtocol.Test\OneScript.DebugProtocol.Test.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScript.DebugServices">OneScript.DebugServices</a></strong></td><td>OneScript.DebugServices\OneScript.DebugServices.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScript.Dynamic.Tests">OneScript.Dynamic.Tests</a></strong></td><td>Tests\OneScript.Dynamic.Tests\OneScript.Dynamic.Tests.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScript.Language">OneScript.Language</a></strong></td><td>OneScript.Language\OneScript.Language.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScript.Language.Tests">OneScript.Language.Tests</a></strong></td><td>Tests\OneScript.Language.Tests\OneScript.Language.Tests.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScript.Native">OneScript.Native</a></strong></td><td>OneScript.Native\OneScript.Native.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScript.StandardLibrary">OneScript.StandardLibrary</a></strong></td><td>OneScript.StandardLibrary\OneScript.StandardLibrary.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#OneScriptDocumenter">OneScriptDocumenter</a></strong></td><td>OneScriptDocumenter\OneScriptDocumenter.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#oscript">oscript</a></strong></td><td>oscript\oscript.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#ScriptEngine">ScriptEngine</a></strong></td><td>ScriptEngine\ScriptEngine.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#ScriptEngine.HostedScript">ScriptEngine.HostedScript</a></strong></td><td>ScriptEngine.HostedScript\ScriptEngine.HostedScript.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#ScriptEngine.NativeApi">ScriptEngine.NativeApi</a></strong></td><td>ScriptEngine.NativeApi\ScriptEngine.NativeApi.vcxproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#Solution Items">Solution Items</a></strong></td><td>Solution Items</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#TestApp">TestApp</a></strong></td><td>TestApp\TestApp.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#Tests">Tests</a></strong></td><td>Tests</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#VSCode.DebugAdapter">VSCode.DebugAdapter</a></strong></td><td>VSCode.DebugAdapter\VSCode.DebugAdapter.csproj</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#">0</a></td></tr><tr><td class="IconSuccessEncoded" /><td><strong><a href="#Solution"><span _locID="OverviewSolutionSpan">Решение</span></a></strong></td><td>1Script.sln</td><td class="textCentered"><a>0</a></td><td class="textCentered"><a>0</a></td><td class="textCentered"><a href="#" onclick="ScrollToFirstVisibleMessage('Solution'); return false;">1</a></td></tr></table></div><h2 _locID="SolutionAndProjectsTitle">Решение и проекты</h2><div id="messages"><a name="Installer" /><h3>Installer</h3><table><tr id="InstallerHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr name="ErrorRowClassInstaller"><td class="IconErrorEncoded"><a name="InstallerError" /></td><td class="messageCell"><strong>Installer\Installer.wixproj: | ||
</strong><span>Приложение, на котором основан этот тип проектов, не найдено. Попробуйте воспользоваться этой ссылкой для получения дополнительной информации: 930c7802-8a8c-48f9-8165-68863bccd9dd</span></td></tr></table><a name="AddInNative" /><h3>AddInNative</h3><table><tr id="AddInNativeHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">AddInNative сообщения не зарегистрированы. | ||
</td></tr></table><a name="Component" /><h3>Component</h3><table><tr id="ComponentHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">Component сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScript.Core" /><h3>OneScript.Core</h3><table><tr id="OneScript.CoreHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScript.Core сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScript.Core.Tests" /><h3>OneScript.Core.Tests</h3><table><tr id="OneScript.Core.TestsHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScript.Core.Tests сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScript.DebugProtocol" /><h3>OneScript.DebugProtocol</h3><table><tr id="OneScript.DebugProtocolHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScript.DebugProtocol сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScript.DebugProtocol.Test" /><h3>OneScript.DebugProtocol.Test</h3><table><tr id="OneScript.DebugProtocol.TestHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScript.DebugProtocol.Test сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScript.DebugServices" /><h3>OneScript.DebugServices</h3><table><tr id="OneScript.DebugServicesHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScript.DebugServices сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScript.Dynamic.Tests" /><h3>OneScript.Dynamic.Tests</h3><table><tr id="OneScript.Dynamic.TestsHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScript.Dynamic.Tests сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScript.Language" /><h3>OneScript.Language</h3><table><tr id="OneScript.LanguageHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScript.Language сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScript.Language.Tests" /><h3>OneScript.Language.Tests</h3><table><tr id="OneScript.Language.TestsHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScript.Language.Tests сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScript.Native" /><h3>OneScript.Native</h3><table><tr id="OneScript.NativeHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScript.Native сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScript.StandardLibrary" /><h3>OneScript.StandardLibrary</h3><table><tr id="OneScript.StandardLibraryHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScript.StandardLibrary сообщения не зарегистрированы. | ||
</td></tr></table><a name="OneScriptDocumenter" /><h3>OneScriptDocumenter</h3><table><tr id="OneScriptDocumenterHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">OneScriptDocumenter сообщения не зарегистрированы. | ||
</td></tr></table><a name="oscript" /><h3>oscript</h3><table><tr id="oscriptHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">oscript сообщения не зарегистрированы. | ||
</td></tr></table><a name="ScriptEngine" /><h3>ScriptEngine</h3><table><tr id="ScriptEngineHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">ScriptEngine сообщения не зарегистрированы. | ||
</td></tr></table><a name="ScriptEngine.HostedScript" /><h3>ScriptEngine.HostedScript</h3><table><tr id="ScriptEngine.HostedScriptHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">ScriptEngine.HostedScript сообщения не зарегистрированы. | ||
</td></tr></table><a name="ScriptEngine.NativeApi" /><h3>ScriptEngine.NativeApi</h3><table><tr id="ScriptEngine.NativeApiHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">ScriptEngine.NativeApi сообщения не зарегистрированы. | ||
</td></tr></table><a name="Solution Items" /><h3>Solution Items</h3><table><tr id="Solution ItemsHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">Solution Items сообщения не зарегистрированы. | ||
</td></tr></table><a name="TestApp" /><h3>TestApp</h3><table><tr id="TestAppHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">TestApp сообщения не зарегистрированы. | ||
</td></tr></table><a name="Tests" /><h3>Tests</h3><table><tr id="TestsHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">Tests сообщения не зарегистрированы. | ||
</td></tr></table><a name="VSCode.DebugAdapter" /><h3>VSCode.DebugAdapter</h3><table><tr id="VSCode.DebugAdapterHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr><td class="IconInfoEncoded" /><td class="messageCell" _locID="NoMessagesRow">VSCode.DebugAdapter сообщения не зарегистрированы. | ||
</td></tr></table><a name="Solution" /><h3 _locID="ProjectDisplayNameHeader">Решение</h3><table><tr id="SolutionHeaderRow"><th></th><th class="messageCell" _locID="MessageTableHeader">Сообщение</th></tr><tr name="MessageRowHeaderShowSolution"><td class="IconInfoEncoded" /><td class="messageCell"><a _locID="ShowAdditionalMessages" href="#" name="SolutionMessage" onclick="ToggleMessageVisibility('Solution'); return false;"> | ||
Показать 1 дополнительные сообщения | ||
</a></td></tr><tr name="MessageRowClassSolution" style="display: none"><td class="IconInfoEncoded"><a name="SolutionMessage" /></td><td class="messageCell"><strong>1Script.sln: | ||
</strong><span>Для файла решения не требуется перенос.</span></td></tr><tr style="display: none" name="MessageRowHeaderHideSolution"><td class="IconInfoEncoded" /><td class="messageCell"><a _locID="HideAdditionalMessages" href="#" name="SolutionMessage" onclick="ToggleMessageVisibility('Solution'); return false;"> | ||
Скрыть 1 дополнительные сообщения | ||
</a></td></tr></table></div></div></body></html> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Скрипты встроены непосредственно в HTML, что ухудшает читаемость и поддержку кода. Рекомендуется вынести JavaScript в отдельные файлы.
Summary by CodeRabbit
Новые функции
Документация