Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An expense requires approval from the second approver again if the final approver approves and subsequently unapproves the report. #54302

Open
1 of 8 tasks
m-natarajan opened this issue Dec 18, 2024 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Dec 18, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.77-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Julesssss
Slack conversation (hyperlinked to channel name): expense

Action Performed:

  1. Create three new users, user A, B & C.
  2. As user A, create a workspace.
  3. Enable delayed submission, and set the frequency to Manual.
  4. Add user B and C to the workspace.
  5. Go to the workflows, and create a new workflow where when user B submits an expense, it requires approval from user C and user A.
  6. As user B, submit an expense to the workspace.
  7. As user C, approve the expense.
  8. As user A, approve the expense.
  9. As user A, Un-approve the expense.

Expected Result:

The expense requires approval from user A only

Actual Result:

The expense requires the approval of both user C and user A again.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Recording.855.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @Julesssss
@m-natarajan m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 18, 2024
Copy link

melvin-bot bot commented Dec 18, 2024

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label Dec 23, 2024
@mallenexpensify
Copy link
Contributor

Was able to reproduce, see user c1 in screenshot below.
image

@Julesssss does this need to be Internal?

@melvin-bot melvin-bot bot removed the Overdue label Dec 23, 2024
@Tony-MK

This comment has been minimized.

@Tony-MK
Copy link
Contributor

Tony-MK commented Dec 23, 2024

@Julesssss does this need to be Internal?

We do need a backend fix but also need a front-end fix to build the next steps optimistically.

@garrettmknight garrettmknight moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 23, 2024
@melvin-bot melvin-bot bot added the Overdue label Dec 26, 2024
Copy link

melvin-bot bot commented Dec 27, 2024

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Copy link

melvin-bot bot commented Dec 31, 2024

@mallenexpensify Still overdue 6 days?! Let's take care of this!

@mallenexpensify
Copy link
Contributor

@Julesssss assigned to you for 👀 once back. Please confirm if this needs to be internal and that

we also need a front-end fix to build the next steps optimistically.

Copy link

melvin-bot bot commented Jan 1, 2025

@Julesssss @mallenexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@Julesssss
Copy link
Contributor

We'll be solving the original bug here before moving forward here.

@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

@Julesssss, @mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@mallenexpensify mallenexpensify added Weekly KSv2 and removed Daily KSv2 labels Jan 7, 2025
@melvin-bot melvin-bot bot removed the Overdue label Jan 7, 2025
@mallenexpensify
Copy link
Contributor

Bumped to weekly since PR is being worked on #52297 (comment)

@garrettmknight garrettmknight added the Internal Requires API changes or must be handled by Expensify staff label Jan 14, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 16, 2025
@Julesssss
Copy link
Contributor

I bumped the PR, as it has been stale for a while.

@melvin-bot melvin-bot bot removed the Overdue label Jan 27, 2025
@melvin-bot melvin-bot bot added the Overdue label Feb 5, 2025
@Julesssss
Copy link
Contributor

I bumped the PR again, asking how I can help

@melvin-bot melvin-bot bot removed the Overdue label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

5 participants