Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid Android - Device navigation bar is black and not green #55217

Closed
1 of 8 tasks
IuliiaHerets opened this issue Jan 14, 2025 · 16 comments
Closed
1 of 8 tasks

Hybrid Android - Device navigation bar is black and not green #55217

IuliiaHerets opened this issue Jan 14, 2025 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Jan 14, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.85-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): Samsung Galaxy Z Fold 4 / Android 14
Issue reported by: Applause Internal Team
Device used: [email protected]
App Component: Left Hand Navigation (LHN)

Action Performed:

Precondition:

  • App theme and device theme are in dark mode.
  • Device navigation is navigation bar and not gestures.
  1. Launch Android hybrid app.
  2. Go to LHN.

Expected Result:

Device navigation bar will flow app color, which is green.

Actual Result:

Device navigation bar is black.
This issue only happens in hybrid app.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6714002_1736864643876.Screen_Recording_20250114_222121_Expensify.1.mp4

Bug6714002_1736864612144!log.txt

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mateuuszzzzz
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Jan 14, 2025
Copy link

melvin-bot bot commented Jan 14, 2025

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 14, 2025

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 14, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 14, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 14, 2025
@mountiny
Copy link
Contributor

This is not a blocker, its because we turned of the edge to edge mode to fix the status overlapping issue.

cc @WoLewicki @staszekscp would anyone from SWM want to work on enabling the edge to edge again? then I could assign them to the follow ups

@IuliiaHerets
Copy link
Author

Our prod build from Play market is on 83-5, not repro on it. So I mark an issue as deploy

screen-20250114-173048.1.mp4

@mateuuszzzzz
Copy link
Contributor

mateuuszzzzz commented Jan 14, 2025

Does this issue have very high priority? I think we could start working on it tomorrow.

Also, we're working on migration Android app from ReactNativeActivity to fragments. On our branch edge 2 edge works pretty well. The catch here is that PR is not ready yet. We still need to adjust a few things and then test it thoroughly since the change is quite complex and fundamentally changes how we handle instance of NewDot on HybridApp. But if priority is not high we could wait with edge 2 edge until Fragments are ready. cc: @mountiny

@mountiny
Copy link
Contributor

I think if you can focus on the fragment tPR to have it ready this week or early next week, then it's fine.

@twisterdotcom
Copy link
Contributor

Should we assign @mateuuszzzzz now?

@twisterdotcom
Copy link
Contributor

How's it going @mateuuszzzzz?

@melvin-bot melvin-bot bot removed the Overdue label Jan 20, 2025
@twisterdotcom twisterdotcom added Weekly KSv2 and removed Daily KSv2 labels Jan 20, 2025
@mateuuszzzzz
Copy link
Contributor

mateuuszzzzz commented Jan 21, 2025

Hi @twisterdotcom, we changed PRs status to ready for a review. Those are complex PRs so QA process should be done before merging it to main

OldDot: https://github.com/Expensify/Mobile-Expensify/pull/13349
NewDot: #55010

@mountiny
Copy link
Contributor

QA is going to run tests on the test build

@mateuuszzzzz
Copy link
Contributor

mateuuszzzzz commented Jan 27, 2025

Hi, we fixed 2 issues found during QA so I presume that we will be able to merge PR soon. It depends on the next round of QA, which should hopefully be a formality at this point 😅

Copy link

melvin-bot bot commented Jan 28, 2025

@twisterdotcom @srikarparsi @mateuuszzzzz this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@mateuuszzzzz
Copy link
Contributor

Hopefully, we will merge those PRs today. We passed QA last week and PRs are ready for a merge

@mountiny
Copy link
Contributor

mountiny commented Feb 4, 2025

It was merged and deployed to staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants