[HOLD for 13349 & 55010] Re-enable the edge to edge mode on Android

[mountiny]

Problem

We had to disable the edge-to-edge mode in the hybrid app on Android 15 because it was causing critical UX issues. The edge-to-edge mode is standard and default in Android 15, and it provides better UX with immersive UI since both the top status bar and the bottom navigation bar connect with the rest of the App design smoothly.

Solution

Re-enable the edge to edge mode and confirm that the hybridApp on all common Android versions looks well.

@kirillzyusko @chrispader @staszekscp @WoLewicki Who would like to work on this? I assume Margelo would be good fit, they should get the hybriad app setup access soon too

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mountiny]

@kirillzyusko @chrispader @hannojg if you would like to take this on, please comment on the issue

[melvin-bot]

@mountiny, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

[kirillzyusko]

@chrispader is going to take this over 👀

[mountiny]

@Kicu seems like this will be done with the hybrid app fragment PR

[mountiny]

Noting its these two PRs:

• https://github.com/Expensify/Mobile-Expensify/pull/13349
• ND changes for Hybrid App switch to fragments on Android #55010

@war-in @Kicu Can you please comment here? We should monitor if all the paddings are right after the PR

[war-in]

Hi, yes! I'm Marcin from Software Mansion and we think this issue should be resolved in mentioned PRs 🎉

[Christinadobrzyn]

Monitoring

https://github.com/Expensify/Mobile-Expensify/pull/13349
#55010

[Christinadobrzyn]

Monitoring

https://github.com/Expensify/Mobile-Expensify/pull/13349
#55010

[Christinadobrzyn]

I'm going to move this to weekly while we wait on those PRs

[ZhenjaHorbach]

@war-in

We have a specific case which is most likely also related to the edge to edge mode

#56205 (comment)

[mountiny]

We just merged the fragments PR in the android hybrid app, I believe we might want to recheck where we are at now

[Christinadobrzyn]

Just checking - @mountiny is rechecking something that we should ask QA to do or something we should ask the team working on this Gh to do?

[mountiny]

@war-in @staszekscp coul dyou please check if there is anything more we need to do now to re-enable the edge to edge?

[war-in]

@mountiny I think the edge-to-edge mode is correctly enabled in HybridApp now and the last thing to do is to remove @staszekscp's PR disabling the mode in OD.
Currently, we enable it programmatically, so the line in themes.xml is just ignored

Let's wait for @staszekscp to confirm and I'll prepare the revert in the meantime

[war-in]

The revert is ready: https://github.com/Expensify/Mobile-Expensify/pull/13415

[staszekscp]

The fix was applied so the edge-to-edge doesn't break the OldDot part of the app - as far as I remember the problem was that users were unable to press buttons on the top of the screen on Android 15 - did you have chance to see if everything works fine there?

[mountiny]

@staszekscp @war-in correct, the issue was in Android 15 specifically and the top was overlapping with the status bar which made it impossible to click on the oldDot buttons in the top.

Can you please check if the oldDot works fine in Android 15 also after force closing the app etc

[war-in]

It took some time but I finally have an answer and solution!
@staszekscp and @mountiny you were right, after removing the flag, the status and nav bars were broken on android 15. The color was always white, even on the sign-in page.

I dug into the code and found places where improvements should be made. Finally, I managed to adjust the old app to handle edge-to-edge properly 🎉 (we no longer need to set paddings when switching between apps)

Please, look at the videos and let me know what you think about the changes!

Gesture navigation:

Screen.Recording.Feb.10.2025.from.Expensify.Dev.mp4

Button navigation:

Screen.Recording.Feb.10.2025.from.Jan.and.Mateusz.mp4

Sign-in page:

Screen.Recording.Feb.10.2025.from.Marcin.Warchol.mp4