Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - No results triggered when searching for valid words in chat search. #56028

Closed
3 of 8 tasks
mitarachim opened this issue Jan 30, 2025 · 11 comments
Closed
3 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@mitarachim
Copy link

mitarachim commented Jan 30, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.92-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Search

Action Performed:

  1. Open the staging.new.expensify.com website.
  2. Open any chat.
  3. Send some messages to the chat.
  4. Tap on the search icon on the top right corner.
  5. Tap on "Search in this chat"
  6. Write a word that should trigger results.

Expected Result:

Correct content should be displayed after the user searches for any word included in a conversation.

Actual Result:

No results are triggered after the user searches for valid words in chat search.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6728116_1738204523211.Results.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @luacmartins
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 30, 2025
Copy link

melvin-bot bot commented Jan 30, 2025

Triggered auto assignment to @techievivek (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 30, 2025

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 30, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@github-actions github-actions bot added Hourly KSv2 and removed Daily KSv2 labels Jan 30, 2025
@techievivek
Copy link
Contributor

We can certainly demote this since it seems to be working all chats but workspace.

@techievivek
Copy link
Contributor

@luacmartins I tested this across various chats and it seems to be working for most except the workspace chat, I looked at the response data for WS chat and it seems like backend is not returning anything. Would you want to take over this?

@techievivek techievivek added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 30, 2025
@luacmartins
Copy link
Contributor

Yea, I can look into this

@melvin-bot melvin-bot bot added the Overdue label Feb 3, 2025
Copy link

melvin-bot bot commented Feb 3, 2025

@luacmartins, @isabelastisser Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@isabelastisser
Copy link
Contributor

any updates here, @luacmartins thank you!

@luacmartins
Copy link
Contributor

Not yet, I'll look into it this week

@melvin-bot melvin-bot bot removed the Overdue label Feb 4, 2025
@luacmartins
Copy link
Contributor

I'm unable to reproduce this issue in the selfDM like shown in the OP. As for the workspace chat, like @techievivek mentioned, that's the expected behavior because in the Workspace chat the default behavior is searching for expenses, not chats. So you'd have to change the type to chat to see the results. When I do that, I can find them without issues.

Gonna close this issue. Please reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants