Workspace - Clicking on account settings navigates to workspace settings

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 11/ Chrome, Android 13/ Chrome
App Component: User Settings

Action Performed:

1. sign in to staging.new.expensify.com
2. Navigate to account settings > Workspaces
3. Click on a workspace (Create a workspace if there isn't any)
4. Navigate to workspace chat from the workspace settings
5. Click on account settings

Expected Result:

Clicking on account settings should display contents of account settings.

Actual Result:

When clicking on account settings, it navigate to workspace settings.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6741305_1739401149727.bandicam_2025-02-13_01-51-49-520.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When clicking on account settings, it navigate to workspace settings.

What is the root cause of that problem?

We normally navigate when click here

App/src/pages/workspace/WorkspaceInitialPage.tsx

Line 497 in a0a2609

onPress={() => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(currentUserPolicyExpenseChat?.reportID))}

and it will be remembered as comment here

App/src/components/Navigation/BottomTabBar/index.tsx

Lines 173 to 188 in a0a2609

	// If there is a workspace navigator route, then we should open the workspace initial screen as it should be "remembered".
	if (lastSettingsOrWorkspaceNavigatorRoute.name === NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR) {
	const params = state?.routes.at(0)?.params as WorkspaceSplitNavigatorParamList[typeof SCREENS.WORKSPACE.INITIAL];
	// Screens of this navigator should always have policyID
	if (params.policyID) {
	// This action will put settings split under the workspace split to make sure that we can swipe back to settings split.
	navigationRef.dispatch({
	type: CONST.NAVIGATION.ACTION_TYPE.OPEN_WORKSPACE_SPLIT,
	payload: {
	policyID: params.policyID,
	},
	});
	}
	return;
	}

What changes do you think we should make in order to solve the problem?

We should add forceReplace = true to pop the current screen of the current stack

        onPress={() => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(currentUserPolicyExpenseChat?.reportID), {forceReplace: true})}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mitarachim]

This issue probably consider as new expected behavior according to PR #49539

[mountiny]

Correct, this is new expected behaviour