QBO - The app does not redirects to the Export page after a value is selected

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #49539
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Workspace Settings

Action Performed:

Precondition: Workspace with QBO integration connected.

1. https://staging.new.expensify.com/
2. Go to Workspace > Accounting.
3. Click on Export > Preferred exporter
4. Click on value.

Expected Result:

When the value chosen in the third step is selected, the app redirects to the Export page.

Actual Result:

The app does not redirects to the Export page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6741580_1739430260092.Screen_Recording_2025-02-13_at_9.11.29_in_the_morning.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @parasharrajat

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @youssef-lr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

⚠️ @parasharrajat Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[parasharrajat]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After selecting a Preferred exporter , user is not taken back to the Export Settings page.

What is the root cause of that problem?

There are two issues that I noticed.

1. Selecting the exporter throws an error in the code as we are trying to access a property that does not exist.

2. We are using the wrong route on the same page. It should be an export page.

https://github.com/Expensify/App/blob/main/src/pages/workspace/accounting/qbo/export/QuickbooksPreferredExporterConfigurationPage.tsx#L59

What changes do you think we should make in order to solve the problem?

1. We should add a check for null value on exporter prop.
   

   App/src/pages/workspace/accounting/qbo/export/QuickbooksPreferredExporterConfigurationPage.tsx

   Line 57 in 4f3a2ee

   QuickbooksOnline.updateQuickbooksOnlinePreferredExporter(policyID, {exporter: row.value}, {exporter: qboConfig?.export.exporter ?? ''});

QuickbooksOnline.updateQuickbooksOnlinePreferredExporter(policyID, {exporter: row.value}, {exporter: qboConfig?.export?.exporter ?? ''});

2. We should change the route to Export page.

ROUTES.POLICY_ACCOUNTING_QUICKBOOKS_ONLINE_EXPORT.getRoute(policyID)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, I belive its a mistake. But happy to work on suggestions.

What alternative solutions did you explore? (Optional)

None.

[parasharrajat]

I can fix this asap.

[parasharrajat]

This issue is not caused by #49539. Looks like it was already present. Probably not a deploy blocker. cc: @mountiny

[SzymczakJ]

Whoops linked my PR to this issue by mistake