Search - "Not found page" not shown for Search page with invalid query parameters

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #49539
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 14.5/ Chrome
App Component: Search

Action Performed:

1. Open App
2. Open the search page with invalid query parameters (e.g /search?q=from%3a)

Expected Result:

The not found page is shown

Actual Result:

The not found page is not shown

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6741496_1739422952794.Screen_Recording_2025-02-13_at_7.48.06_in_the_morning.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Kicu]

IMO ?q=from%3a is not an invalid query parameters. This is simply empty from: clause. Yes, the search will return nothing in that case, but it does not break it.

For any query that technically is correct (no weird characters, no errors) but makes no logical sense (like search for something empty) we have decided to simply display empty results view.
Not sure if we want to change it to full "Not found" page 🤔

CC @luacmartins

[luacmartins]

Yea, I don't think this is a bug. We're working on a separate issue to show an error message if the user does indeed submit an invalid query and we get a 5xx error back from the server. We can close this issue!