Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MomentProcess -> Coroutine #274

Open
bddckr opened this issue Feb 9, 2019 · 1 comment
Open

MomentProcess -> Coroutine #274

bddckr opened this issue Feb 9, 2019 · 1 comment
Labels
enhancement Making something better

Comments

@bddckr
Copy link
Contributor

bddckr commented Feb 9, 2019

Evaluate whether this brings performance improvements and can offer the same "moments".
@bddckr bddckr added the enhancement Making something better label Feb 9, 2019
@fight4dream fight4dream mentioned this issue Aug 8, 2019
Open
@fight4dream
Copy link
Contributor

I happened to create a CoroutineMomentProcessor from the refractor attempt of BehaviourEnabledObserver. The added functionalities (Interval, MaximumRunTime) are originated from the observer.

I have not evaluate the performance, but with respect to BehaviourEnabledObserver, it will behave the same (because it also used coroutine before refractoring).

image

whether ... can offer the same "moments".

anything in the Coroutine before the first yield would be executed immediately from calling site. anything after the first yield is executed right after Update(). So it cannot offer any moments other than 'RightAfterUpdate'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Making something better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bddckr @fight4dream