Button style in close window dialog

[cavearr]

@lmcapacho thanks for this feature, i change the literals to do more clear, if you think are few large, try other options but it is important define clearly the operative (save and close, etc).

If you could put a "red ribbon" to this develop, define a better style to the buttons, according to other ui buttons of iceStudio:

Thanks!

[lmcapacho]

Hi @cavearr

Thanks for your feedback!

Previously, the buttons were named "Close" and "Cancel". How do feel about changing them to "Save and Close", "Discard and Close", and "Cancel"?

As for the button styles, they currently match the design used in other windows and buttons in Icestudio, following the theme used in Alertify. Could you share more about your idea?

[cavearr]

@lmcapacho as you see in white theme (i don't try yet in dark theme) there are no buttons, appears links. i think we need to define a thin border like the "Import" in verilog form.

[cavearr]

@lmcapacho For me, my thoughts:

1. 💾 Save & Quit
2. NO save & Quit
3. Back ⏎

How do you think? Cancel is ambiguous because what do you cancel, the dialog, the save , .....i think back is clearly, the button return to your previous state.

With "quit" we gain small word and clear action.

For save changes, i think we should use save for both cases, because "cancel" is again ambiguos , what do you want to cancel? (the dialog, the changes, the windows closing....).

We could use unicode icons like save or back to do emphasis in the action. the point 2 i don't find an standard icon that like me, but i think could be fine without icon.

[TimRudy]

I think it is common to say "Save and Quit" plus "Quit without saving" or "Quit without save" . [The capitalization of the words, i.e. "saving"/"Saving"/"Save" is a question. We can search for commonly used pattern or ask ChatGPT.]

…

On Tue, Jan 21, 2025 at 12:33 PM Carlos Venegas Arrabé < ***@***.***> wrote: @lmcapacho <https://github.com/lmcapacho> For me, my thoughts: 1. 💾 Save & Quit 2. NO save & Quit 3. Back ⏎ How do you think? Cancel is ambiguous because what do you cancel, the dialog, the save , .....i think back is clearly, the button return to your previous state. With "quit" we gain small word and clear action. For save changes, i think we should use save for both cases, because "cancel" is again ambiguos , what do you want to cancel? (the dialog, the changes, the windows closing....). We could use unicode icons like save or back to do emphasis in the action. the point 2 i don't find an standard icon that like me, but i think could be fine without icon. — Reply to this email directly, view it on GitHub <#806 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AA6CTIQLVDPOCYZ6QHIKLF32L2AHRAVCNFSM6AAAAABVR3OBFCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMBVGM2TCOBVGA> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>