Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instance Java runtime arguments #1191

Closed
Gaz492 opened this issue Aug 9, 2024 · 2 comments
Closed

Instance Java runtime arguments #1191

Gaz492 opened this issue Aug 9, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Gaz492
Copy link
Member

Gaz492 commented Aug 9, 2024

What Operating System

MacOS (Latest)

Debug Code

N/A

Describe the bug

Clicking the Reset to default button next to the Java runtime arguments setting while in the modpack specific settings does not reset it to the value set in the global instance default settings, it uses the hardcoded default that ship with the app.

Steps to reproduce

  1. Change global instance defaults runtime arguments to something else
  2. Go to a modpack and click settings
  3. Click the reset default button next to the Java runtime arguments
  4. Witness it not set it to whats in the instance defaults

Expected behaviour

It resets the instance Java runtime arguments to whats set in the instance defaults

Screenshots

No response

Additional information

No response

@Gaz492 Gaz492 added the bug Something isn't working label Aug 9, 2024

This comment was marked as off-topic.

@MichaelHillcox
Copy link
Member

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants