Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Entity#checkDespawn method implies that despawning does not occur within the method #3749

Open
haykam821 opened this issue Dec 7, 2023 · 0 comments

Comments

@haykam821
Copy link
Contributor

I think the Entity#checkDespawn method would make more sense if it were named Entity#tryDespawn or similar. The method calls the Entity#discard method itself, rather than returning a boolean. For example, shulker bullets override the method like so:

@Override
public void checkDespawn() {
	if (this.getWorld().getDifficulty() == Difficulty.PEACEFUL) {
		this.discard();
	}
}

Note that a different TraderLlamaEntity#tryDespawn method already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant