Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: rename Bans to AccountBanScreens #3990

Open
wants to merge 3 commits into
base: 24w38a
Choose a base branch
from

Conversation

Octol1ttle
Copy link
Contributor

Fixes #3904

I thought about changing the package but I couldn't find any better place for this file

@apple502j
Copy link
Contributor

Does this handle a BanScreen, though?

@Octol1ttle
Copy link
Contributor Author

Can you please elaborate, there's no class with the name BanScreen

@Octol1ttle Octol1ttle changed the title change: rename Bans to BanScreens change: rename Bans to AccountBanScreens Sep 21, 2024
@Shnupbups
Copy link
Contributor

It seems you've accidentally removed the renamed mapping class...

@Octol1ttle
Copy link
Contributor Author

It seems you've accidentally removed the renamed mapping class...

git did a lulz

@Shnupbups Shnupbups requested a review from a team September 27, 2024 04:52
@Shnupbups Shnupbups added refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor A PR that renames existing names. snapshot A PR that targets a snapshot version of Minecraft
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Bans class is used only for creating game ban screens
3 participants