Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value check of GetSource()->InitUnpackers() #1301

Closed
inkdot7 opened this issue Dec 1, 2022 · 2 comments
Closed

Return value check of GetSource()->InitUnpackers() #1301

inkdot7 opened this issue Dec 1, 2022 · 2 comments

Comments

@inkdot7
Copy link

inkdot7 commented Dec 1, 2022 •
edited
Loading

The return value of GetSource()->InitUnpackers() is not checked in

FairRoot/online/steer/FairRunOnline.cxx

Line 192 in 95b6b43

GetSource()->InitUnpackers();

This leads to inconsistent results in r3broot, see R3BRootGroup/R3BRoot#705

Should the return value be checked in FairRunOnline::Init() ?
karabowi added a commit to karabowi/FairRoot that referenced this issue Dec 9, 2022
@karabowi
Check the return value source->InitUnpackers
5045967 
Return values of the calls to `source->InitUnpackers()`
and `source->ReinitUnpackers()` in `FairRunOnline`
are now checked. Should the value be `false`,
the fatal message will be printed.

Addresses issue FairRootGroup#1301.
@karabowi karabowi mentioned this issue Dec 9, 2022
Merged
3 tasks
@karabowi
Copy link
Collaborator

@inkdot7 , could you test the PR #1307 and leave us feedback on the performance?

@inkdot7 inkdot7 mentioned this issue Dec 12, 2022
Open
karabowi added a commit to karabowi/FairRoot that referenced this issue Dec 22, 2022
@karabowi
Check the return value source->InitUnpackers
8bcb974 
Return values of the calls to `source->InitUnpackers()`
and `source->ReinitUnpackers()` in `FairRunOnline`
are now checked. Should the value be `false`,
the fatal message will be printed.

Addresses issue FairRootGroup#1301.
karabowi added a commit to karabowi/FairRoot that referenced this issue Jan 10, 2023
@karabowi
Check the return value source->InitUnpackers
e941911 
Return values of the calls to `source->InitUnpackers()` and
`source->ReinitUnpackers()` in `FairRunOnline` are now checked.
Should the value be `false`, the fatal message will be printed.

Addresses issue FairRootGroup#1301.
karabowi added a commit to karabowi/FairRoot that referenced this issue Jan 11, 2023
@karabowi
Check the return value source->InitUnpackers
76c5a93 
Return values of the calls to `source->InitUnpackers()` and
`source->ReinitUnpackers()` in `FairRunOnline` are now checked.
Should the value be `false`, the fatal message will be printed.

Addresses issue FairRootGroup#1301.
karabowi added a commit to karabowi/FairRoot that referenced this issue Jan 16, 2023
@karabowi
Check the return value source->InitUnpackers
e91f9b9 
Return values of the calls to `source->InitUnpackers()` and
`source->ReinitUnpackers()` in `FairRunOnline` are now checked.
Should the value be `false`, the fatal message will be printed.

Addresses issue FairRootGroup#1301.
karabowi added a commit that referenced this issue Jan 18, 2023
@karabowi
Check the return value source->InitUnpackers
eb3985a 
Return values of the calls to `source->InitUnpackers()` and
`source->ReinitUnpackers()` in `FairRunOnline` are now checked.
Should the value be `false`, the fatal message will be printed.

Addresses issue #1301.
@inkdot7
Copy link
Author

inkdot7 commented Feb 1, 2023

Thanks for merging the fix!

@inkdot7 inkdot7 closed this as completed Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@inkdot7 @karabowi