Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Review #1

Open
pi0 opened this issue Jul 22, 2017 · 1 comment
Open

Initial Review #1

pi0 opened this issue Jul 22, 2017 · 1 comment

Comments

@pi0
Copy link

pi0 commented Jul 22, 2017

Hi.

  • Always exclude node_modules using .gitignore file. Commit only (source)
  • Make sure removing examples when using starter template. (Extra files like components/Logo.vue) before initial commit
  • Avoid inline styles like this & prefer css selectors (Also should be scoped like <style scoped> ...)
    • Exception: When simple style needed for layout and positioning and no utility is available for exact use case.
  • Avoid camel case file names (Prefer dash)
  • Prefer dash for css class names (comment_text-> comment-text)
  • Use camel case for js variables (just a note)
  • Avoid import * as axios from 'axios' for performance and bundle size. (Use import axios from 'axios')
  • here
    : prefer bootstrap 4 utilitis like mr-3
  • Avoid vendor specific selectors like this Nuxt/Webpack will handle it
  • Update nuxt.config.js head section.
@pi0
Copy link
Author

pi0 commented Jul 22, 2017

Update:

  • Assets renamed but changes not applied to code!
  • Use Layouts for writing navigation once!
  • Use 1 commit for one change not a one commit for all!
  • Also gitignore .nuxt directroy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant