From 2999710817ad6f6f4ce30b1d28879a3ca5b1aed8 Mon Sep 17 00:00:00 2001 From: Tatu Saloranta Date: Mon, 27 Jun 2022 17:47:33 -0700 Subject: [PATCH] Minor test changes prepping for #784 --- .../core/read/NonStandardNumberParsingTest.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/fasterxml/jackson/core/read/NonStandardNumberParsingTest.java b/src/test/java/com/fasterxml/jackson/core/read/NonStandardNumberParsingTest.java index 5dfde32431..fdf6af1800 100644 --- a/src/test/java/com/fasterxml/jackson/core/read/NonStandardNumberParsingTest.java +++ b/src/test/java/com/fasterxml/jackson/core/read/NonStandardNumberParsingTest.java @@ -111,7 +111,7 @@ public void testLeadingPlusSignInDecimalAllowedBytes() throws Exception { public void testLeadingPlusSignInDecimalAllowedReader() throws Exception { _testLeadingPlusSignInDecimalAllowed(jsonFactory(), MODE_READER); -// _testLeadingPlusSignInDecimalAllowed(jsonFactory(), MODE_READER_THROTTLED); + _testLeadingPlusSignInDecimalAllowed(jsonFactory(), MODE_READER_THROTTLED); } public void testLeadingDotInNegativeDecimalAllowedAsync() throws Exception { @@ -144,6 +144,8 @@ private void _testLeadingPlusSignInDecimalAllowed(JsonFactory f, int mode) throw assertEquals(JsonToken.VALUE_NUMBER_INT, p.nextToken()); assertEquals(125.0, p.getValueAsDouble()); assertEquals("125", p.getDecimalValue().toString()); + // 27-Jun-2022, tatu: As per [core#784] this SHOULD include leading + // plug sign assertEquals("125", p.getText()); } try (JsonParser p = createParser(f, mode, " +0.125 ")) { @@ -156,7 +158,12 @@ private void _testLeadingPlusSignInDecimalAllowed(JsonFactory f, int mode) throw assertEquals(JsonToken.VALUE_NUMBER_FLOAT, p.nextToken()); assertEquals(0.125, p.getValueAsDouble()); assertEquals("0.125", p.getDecimalValue().toString()); - assertEquals("+.125", p.getText()); + // 27-Jun-2022, tatu: As per [core#784] this SHOULD include leading + // plug sign. But worse, looks like sometimes it does sometimes not + final String text = p.getText(); + if (!"+.125".equals(text) && !".125".equals(text)) { + fail("Bad textual representation: ["+text+"]"); + } } }