Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAIL_ON_IGNORED_PROPERTIES does not throw on READONLY properties with an explicit name #2719

Closed
bidorffOL opened this issue May 13, 2020 · 0 comments · Fixed by #2720
Closed

FAIL_ON_IGNORED_PROPERTIES does not throw on READONLY properties with an explicit name #2719

bidorffOL opened this issue May 13, 2020 · 0 comments · Fixed by #2720
Milestone
2.12.0

Comments

@bidorffOL
Copy link
Contributor

As mentioned in the title, FAIL_ON_IGNORED_PROPERTIES does not throw on properties annotated with @JsonProperty(value = 'XXX', access = JsonProperty.Access.READ_ONLY). I believe that it is because the implicit name of the property is added to the list of ignorals in POJOPropertiesCollector rather than the explicit names when at least one is available.

I have prepared a Pull Request for this issue, I'll provide it as soon as possible.
@bidorffOL bidorffOL mentioned this issue May 13, 2020
Merged
@cowtowncoder cowtowncoder changed the title FAIL_ON_IGNORED_PROPERTIES does not throw on READONLY properties with an explicit name FAIL_ON_IGNORED_PROPERTIES does not throw on READONLY properties with an explicit name May 17, 2020
@cowtowncoder cowtowncoder added this to the 2.12.0 milestone May 17, 2020
cowtowncoder added a commit that referenced this issue May 17, 2020
@cowtowncoder
Update release notes wrt #2719 (and minor optimization wrt fix)
e6df267
@cowtowncoder cowtowncoder mentioned this issue May 17, 2020
Closed
@cowtowncoder cowtowncoder mentioned this issue Jul 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.12.0
Development

Successfully merging a pull request may close this issue.

Ignore the explicit names of READONLY properties when they are available
2 participants
@cowtowncoder @bidorffOL